ec/roda/it8518/acpi: Make use of `Printf("...")`
Replace `Store("...", Debug)` with `Printf("...")`.
Built roda/rw11 with `BUILD_TIMELESS=1` and coreboot.rom remains the
same.
Change-Id: Ie1a1f7320ef2850e4f861b1426240e6940036844
Signed-off-by: Felix Singer <felix.singer@secunet.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56602
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
diff --git a/src/ec/roda/it8518/acpi/ac.asl b/src/ec/roda/it8518/acpi/ac.asl
index c46bf20..ec8c704 100644
--- a/src/ec/roda/it8518/acpi/ac.asl
+++ b/src/ec/roda/it8518/acpi/ac.asl
@@ -9,8 +9,8 @@
Method (_PSR, 0, NotSerialized) // _PSR: Power Source
{
- Store ("-----> AC: _PSR", Debug)
- Store ("<----- AC: _PSR", Debug)
+ Printf ("-----> AC: _PSR")
+ Printf ("<----- AC: _PSR")
Return (PWRS)
}
}
diff --git a/src/ec/roda/it8518/acpi/battery.asl b/src/ec/roda/it8518/acpi/battery.asl
index 04fe769..38b6ed3 100644
--- a/src/ec/roda/it8518/acpi/battery.asl
+++ b/src/ec/roda/it8518/acpi/battery.asl
@@ -42,7 +42,7 @@
// Battery Slot Status
Method (_STA, 0, Serialized)
{
- Store ("-----> BAT0: _STA", Debug)
+ Printf ("-----> BAT0: _STA")
Store (0x0F, Local0)
@@ -53,27 +53,27 @@
Store (0x1F, Local0)
}
- Store ("<----- BAT0: _STA", Debug)
+ Printf ("<----- BAT0: _STA")
Return (Local0)
}
Method (_BIF, 0, Serialized)
{
- Store ("-----> BAT0: _BIF", Debug)
+ Printf ("-----> BAT0: _BIF")
Store (B0FC, Index (PBIF, 0x02))
Store (Divide (Multiply (B0FC, 6), 100), Index (PBIF, 0x05))
Store (Divide (Multiply (B0FC, 3), 100), Index (PBIF, 0x06))
- Store ("<----- BAT0: _BIF", Debug)
+ Printf ("<----- BAT0: _BIF")
Return (PBIF)
}
Method (_BST, 0, Serialized)
{
- Store ("-----> BAT0: _BST", Debug)
+ Printf ("-----> BAT0: _BST")
Store (B0ST, Local0)
And (Local0, 0x40, Local0)
@@ -103,7 +103,7 @@
Store (B0RC, Index (PBST, 0x02))
Store (B0VT, Index (PBST, 0x03))
- Store ("<----- BAT0: _BST", Debug)
+ Printf ("<----- BAT0: _BST")
Return (PBST)
}
diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl
index 28f9c88..6542bc39 100644
--- a/src/ec/roda/it8518/acpi/ec.asl
+++ b/src/ec/roda/it8518/acpi/ec.asl
@@ -51,16 +51,16 @@
Method (_REG, 2, NotSerialized)
{
- Store ("-----> EC: _REG", Debug)
+ Printf ("-----> EC: _REG")
Store (0x01, ECOS)
- Store ("<----- EC: _REG", Debug)
+ Printf ("<----- EC: _REG")
}
Method (_Q29, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q29", Debug)
+ Printf ("-----> EC: _Q29")
Store (1, PWRS)
Notify (AC, 0x80)
@@ -68,12 +68,12 @@
Notify (BAT0, 0x00)
Notify (BAT0, 0x80)
- Store ("<----- EC: _Q29", Debug)
+ Printf ("<----- EC: _Q29")
}
Method (_Q31, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q31", Debug)
+ Printf ("-----> EC: _Q31")
Store (0, PWRS)
Notify (AC, 0x80)
@@ -81,12 +81,12 @@
Notify (BAT0, 0x00)
Notify (BAT0, 0x80)
- Store ("<----- EC: _Q31", Debug)
+ Printf ("<----- EC: _Q31")
}
Method (_Q32, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q32", Debug)
+ Printf ("-----> EC: _Q32")
Sleep (2500)
Notify (BAT0, 0x00)
@@ -94,12 +94,12 @@
Notify (BAT0, 0x81)
Notify (BAT0, 0x82)
- Store ("<----- EC: _Q32", Debug)
+ Printf ("<----- EC: _Q32")
}
Method (_Q33, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q33", Debug)
+ Printf ("-----> EC: _Q33")
Sleep (2500)
Notify (BAT0, 0x00)
@@ -107,30 +107,30 @@
Notify (BAT0, 0x81)
Notify (BAT0, 0x82)
- Store ("<---- EC: _Q33", Debug)
+ Printf ("<---- EC: _Q33")
}
Method (_Q36, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q36", Debug)
+ Printf ("-----> EC: _Q36")
Notify (BAT0, 0x80)
- Store ("<----- EC: _Q36", Debug)
+ Printf ("<----- EC: _Q36")
}
Method (_Q37, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q37", Debug)
+ Printf ("-----> EC: _Q37")
Notify (BAT0, 0x80)
- Store ("<----- EC: _Q37", Debug)
+ Printf ("<----- EC: _Q37")
}
Method (_Q43, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q43", Debug)
+ Printf ("-----> EC: _Q43")
Store (BRIG, Local0)
Increment (Local0)
@@ -141,12 +141,12 @@
\_SB.PCI0.GFX0.INCB ()
- Store ("<---- EC: _Q43", Debug)
+ Printf ("<---- EC: _Q43")
}
Method (_Q44, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q44", Debug)
+ Printf ("-----> EC: _Q44")
Store (BRIG, Local0)
Decrement (Local0)
@@ -158,36 +158,36 @@
\_SB.PCI0.GFX0.DECB ()
- Store ("<---- EC: _Q44", Debug)
+ Printf ("<---- EC: _Q44")
}
Method (_Q45, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q45", Debug)
+ Printf ("-----> EC: _Q45")
Store (0, LIDS)
Notify (LID, 0x80)
- Store ("<----- EC: _Q45", Debug)
+ Printf ("<----- EC: _Q45")
}
Method (_Q46, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q46", Debug)
+ Printf ("-----> EC: _Q46")
Store (1, LIDS)
Notify (LID, 0x80)
- Store ("<----- EC: _Q46", Debug)
+ Printf ("<----- EC: _Q46")
}
Method (_Q70, 0, NotSerialized) // _Qxx: EC Query
{
- Store ("-----> EC: _Q70", Debug)
+ Printf ("-----> EC: _Q70")
Notify (ALSD, 0x80)
- Store ("<----- EC: _Q70", Debug)
+ Printf ("<----- EC: _Q70")
}
#include "battery.asl"
diff --git a/src/ec/roda/it8518/acpi/lid.asl b/src/ec/roda/it8518/acpi/lid.asl
index c30bb4d..61eda55 100644
--- a/src/ec/roda/it8518/acpi/lid.asl
+++ b/src/ec/roda/it8518/acpi/lid.asl
@@ -7,8 +7,8 @@
Name (_HID, EisaId ("PNP0C0D")) // _HID: Hardware ID
Method (_LID, 0, NotSerialized) // _LID: Lid Status
{
- Store ("-----> LID0: _LID", Debug)
- Store ("<----- LID0: _LID", Debug)
+ Printf ("-----> LID0: _LID")
+ Printf ("<----- LID0: _LID")
Return (LIDS)
}
}