soc/intel/cmn/tcss: Skip sending CONN IPC command during S3 resume
This patch skips sending CONN IPC command to PMC if system is resuming
from S3.
Sending CONN IPC command as part of `tcss_configure_dp_mode()` function
results into ERROR while system is resuming from S3.
Additionally, skip `configure_aux_bias_pads()` during S3 resume.
BUG=b:260984500
TEST=Able to test on Google/Rex.
Without this patch:
[ERROR] pmc_send_ipc_cmd status: fatal
[ERROR] Port 1 connect request failed
[SPEW ] [TCSS] TcssInit() - End
With this patch:
No error seen during S3 resume.
Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I1dab7dc8b4ad76ca0c9630456803c1b9a320fe40
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70222
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c
index b4a5a0e..2ae07fd 100644
--- a/src/soc/intel/common/block/tcss/tcss.c
+++ b/src/soc/intel/common/block/tcss/tcss.c
@@ -409,14 +409,14 @@
if (!platform_is_resuming()) {
for (i = 0; i < num_ports; i++)
tcss_init_mux(i, &port_map[i]);
+
+ /* This should be performed before alternate modes are entered */
+ if (tcss_ops.configure_aux_bias_pads)
+ tcss_ops.configure_aux_bias_pads(aux_bias_pads);
+
+ if (CONFIG(ENABLE_TCSS_DISPLAY_DETECTION))
+ tcss_configure_dp_mode(port_map, num_ports);
}
-
- /* This should be performed before alternate modes are entered */
- if (tcss_ops.configure_aux_bias_pads)
- tcss_ops.configure_aux_bias_pads(aux_bias_pads);
-
- if (CONFIG(ENABLE_TCSS_DISPLAY_DETECTION))
- tcss_configure_dp_mode(port_map, num_ports);
}
bool tcss_valid_tbt_auth(void)