commit 8ad52fff6464b502a6d839774c2dbddf5fbffd4f
author Kyösti Mälkki <kyosti.malkki@gmail.com> Sat May 30 14:50:50 2020 +0300
committer Felix Held <felix-coreboot@felixheld.de> Wed Jun 10 01:00:54 2020 +0000
tree d31feb1c601f3c658bcde1ec23568f80d5b2f99b
parent df63ff8b5582c66671758a639f929c9f63b229f7

sb/intel/i82371eb: Select COMMON_FADT

Change-Id: I0b1f3e16b2a801e5fcf5f96d59922f6231d73636
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41925
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/southbridge/intel/i82371eb/fadt.c

diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index 66781be..711b37e 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -16,23 +16,8 @@
  * Create the Fixed ACPI Description Tables (FADT) for any board with this SB.
  * Reference: ACPIspec40a, 5.2.9, page 118
  */
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
+void acpi_fill_fadt(acpi_fadt_t *fadt)
 {
-	acpi_header_t *header = &(fadt->header);
-
-	/* Power management controller */
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_1_0;
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (uintptr_t)facs;
-	fadt->dsdt = (uintptr_t)dsdt;
 	fadt->preferred_pm_profile = 0; /* unspecified */
 	fadt->sci_int = 9;
 
@@ -137,11 +122,6 @@
 	fadt->reset_reg.addrh = 0x0;
 	fadt->reset_value = 0;
 
-	fadt->x_firmware_ctl_l = (uintptr_t)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (uintptr_t)dsdt;
-	fadt->x_dsdt_h = 0;
-
 	fadt->x_pm1a_evt_blk.space_id = 1;
 	fadt->x_pm1a_evt_blk.bit_width = fadt->pm1_evt_len * 8;
 	fadt->x_pm1a_evt_blk.bit_offset = 0;
@@ -198,5 +178,4 @@
 	fadt->x_gpe1_blk.addrl = fadt->gpe1_blk;
 	fadt->x_gpe1_blk.addrh = 0x0;
 
-	header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t));
 }