SPI: Fix command-response behavior
Fix SPI flash ops regressions after commit:
c2973d1 spi: Get rid of SPI_ATOMIC_SEQUENCING
When spi_flash_cmd() is called with argument response==NULL,
only send out command without reading back the response.
Change-Id: I28a94f208b4a1983d45d69d46db41391e267891d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/18082
Tested-by: build bot (Jenkins)
Reviewed-by: Timothy Pearson <tpearson@raptorengineering.com>
Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c
index a0e3105..95362f2 100644
--- a/src/drivers/spi/spi_flash.c
+++ b/src/drivers/spi/spi_flash.c
@@ -49,11 +49,14 @@
[1] = { .dout = NULL, .bytesout = 0,
.din = din, .bytesin = bytes_in },
};
+ size_t count = ARRAY_SIZE(vectors);
+ if (!bytes_in)
+ count = 1;
if (spi_claim_bus(spi))
return ret;
- if (spi_xfer_vector(spi, vectors, ARRAY_SIZE(vectors)) == 0)
+ if (spi_xfer_vector(spi, vectors, count) == 0)
ret = 0;
spi_release_bus(spi);