soc/amd/picasso/uart: make index parameters unsigned
The UART index is never negative, so make it unsigned and drop the check
for the index to be non-negative.
BRANCH=zork
Change-Id: I38b5dad87f8af4fbe8ee1d919230efe48f68686c
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45292
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
diff --git a/src/soc/amd/picasso/uart.c b/src/soc/amd/picasso/uart.c
index d892333..0bf7eb8 100644
--- a/src/soc/amd/picasso/uart.c
+++ b/src/soc/amd/picasso/uart.c
@@ -32,9 +32,9 @@
} },
};
-uintptr_t get_uart_base(int idx)
+uintptr_t get_uart_base(unsigned int idx)
{
- if (idx < 0 || idx >= ARRAY_SIZE(uart_info))
+ if (idx >= ARRAY_SIZE(uart_info))
return 0;
return uart_info[idx].base;
@@ -45,12 +45,12 @@
write16((void *)FCH_UART_LEGACY_DECODE, 0);
}
-void set_uart_config(int idx)
+void set_uart_config(unsigned int idx)
{
uint32_t uart_ctrl;
uint16_t uart_leg;
- if (idx < 0 || idx >= ARRAY_SIZE(uart_info))
+ if (idx >= ARRAY_SIZE(uart_info))
return;
program_gpios(uart_info[idx].mux, 2);