commit 7f72c641957344e05176b7f31b0fffca434f4be7
author Rizwan Qureshi <rizwan.qureshi@intel.com> Wed Oct 04 18:53:19 2017 +0530
committer Martin Roth <martinroth@google.com> Thu Oct 05 17:47:02 2017 +0000
tree 27bc06dbae2fe35cfea7c68f7f6cc89941704ad5
parent b3e18c7a434700ace381443a0e16718d8c6af7f6

soc/intel/{common,apollolake}: Add checks to handle negative values

Fix issues reported by coverity scan in the below files.

src/soc/intel/common/block/i2c
	1375440: Improper use of negative value
	1375441: Improper use of negative value
	1375444: Improper use of negative value

src/soc/intel/apollolake/i2c.c
	1375442: Unsigned compared against 0

Change-Id: Ic65400c934631e3dcd3aa664c24cb451616e7f4d
Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com>
Reviewed-on: https://review.coreboot.org/21875
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

src/soc/intel/common/block/i2c/i2c.c

diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c
index 625bb99..c6f3be2 100644
--- a/src/soc/intel/common/block/i2c/i2c.c
+++ b/src/soc/intel/common/block/i2c/i2c.c
@@ -96,9 +96,12 @@
 	const struct lpss_i2c_bus_config *config;
 	int bus = lpss_i2c_dev_to_bus(dev);
 
+	if (bus < 0)
+		return;
+
 	config = i2c_get_soc_cfg(bus, dev);
 
-	if (!config || bus < 0)
+	if (!config)
 		return;
 
 	lpss_i2c_init(bus, config);
@@ -126,6 +129,9 @@
 
 	bus = lpss_i2c_dev_to_bus(dev);
 
+	if (bus < 0)
+		return;
+
 	bcfg = i2c_get_soc_cfg(bus, dev);
 
 	if (!bcfg)