AGESA f14/f15tn/f16kb: Factor out memory settings
We use the same values everywhere, so we might as well factor them out.
TEST=Use abuild --timeless to check that all AGESA f14/f15tn/f16kb
mainboards result in identical coreboot binaries.
Change-Id: Ie6f166034d5d642dff37730a8d83264fb2e019b4
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41663
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Krystian Hebel <krystian.hebel@3mdeb.com>
diff --git a/src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h b/src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h
index 2de9de5..883d509 100644
--- a/src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h
@@ -583,7 +583,7 @@
#ifdef BLDCFG_VRM_SLEW_RATE
#define CFG_VRM_SLEW_RATE BLDCFG_VRM_SLEW_RATE
#else
- #define CFG_VRM_SLEW_RATE DFLT_VRM_SLEW_RATE
+ #define CFG_VRM_SLEW_RATE (5000)
#endif
#ifdef BLDCFG_VRM_INRUSH_CURRENT_LIMIT
@@ -613,7 +613,7 @@
#ifdef BLDCFG_VRM_NB_SLEW_RATE
#define CFG_VRM_NB_SLEW_RATE BLDCFG_VRM_NB_SLEW_RATE
#else
- #define CFG_VRM_NB_SLEW_RATE DFLT_VRM_SLEW_RATE
+ #define CFG_VRM_NB_SLEW_RATE (5000)
#endif
#ifdef BLDCFG_VRM_NB_INRUSH_CURRENT_LIMIT
@@ -722,7 +722,7 @@
#ifdef BLDCFG_MEMORY_QUADRANK_TYPE
#define CFG_MEMORY_QUADRANK_TYPE BLDCFG_MEMORY_QUADRANK_TYPE
#else
- #define CFG_MEMORY_QUADRANK_TYPE DFLT_MEMORY_QUADRANK_TYPE
+ #define CFG_MEMORY_QUADRANK_TYPE QUADRANK_UNBUFFERED
#endif
#ifdef BLDCFG_MEMORY_RDIMM_CAPABLE
@@ -848,31 +848,31 @@
#ifdef BLDCFG_SCRUB_DRAM_RATE
#define CFG_SCRUB_DRAM_RATE BLDCFG_SCRUB_DRAM_RATE
#else
- #define CFG_SCRUB_DRAM_RATE DFLT_SCRUB_DRAM_RATE
+ #define CFG_SCRUB_DRAM_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_L2_RATE
#define CFG_SCRUB_L2_RATE BLDCFG_SCRUB_L2_RATE
#else
- #define CFG_SCRUB_L2_RATE DFLT_SCRUB_L2_RATE
+ #define CFG_SCRUB_L2_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_L3_RATE
#define CFG_SCRUB_L3_RATE BLDCFG_SCRUB_L3_RATE
#else
- #define CFG_SCRUB_L3_RATE DFLT_SCRUB_L3_RATE
+ #define CFG_SCRUB_L3_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_IC_RATE
#define CFG_SCRUB_IC_RATE BLDCFG_SCRUB_IC_RATE
#else
- #define CFG_SCRUB_IC_RATE DFLT_SCRUB_IC_RATE
+ #define CFG_SCRUB_IC_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_DC_RATE
#define CFG_SCRUB_DC_RATE BLDCFG_SCRUB_DC_RATE
#else
- #define CFG_SCRUB_DC_RATE DFLT_SCRUB_DC_RATE
+ #define CFG_SCRUB_DC_RATE (0)
#endif
#ifdef BLDCFG_ECC_SYNC_FLOOD
diff --git a/src/vendorcode/amd/agesa/f15tn/Config/PlatformInstall.h b/src/vendorcode/amd/agesa/f15tn/Config/PlatformInstall.h
index 63dae95..d769220 100644
--- a/src/vendorcode/amd/agesa/f15tn/Config/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f15tn/Config/PlatformInstall.h
@@ -1758,7 +1758,7 @@
#ifdef BLDCFG_VRM_SLEW_RATE
#define CFG_VRM_SLEW_RATE BLDCFG_VRM_SLEW_RATE
#else
- #define CFG_VRM_SLEW_RATE DFLT_VRM_SLEW_RATE
+ #define CFG_VRM_SLEW_RATE (5000)
#endif
#ifdef BLDCFG_VRM_MAXIMUM_CURRENT_LIMIT
@@ -1820,7 +1820,7 @@
#ifdef BLDCFG_VRM_NB_SLEW_RATE
#define CFG_VRM_NB_SLEW_RATE BLDCFG_VRM_NB_SLEW_RATE
#else
- #define CFG_VRM_NB_SLEW_RATE DFLT_VRM_SLEW_RATE
+ #define CFG_VRM_NB_SLEW_RATE (5000)
#endif
#ifdef BLDCFG_PLAT_NUM_IO_APICS
@@ -1928,7 +1928,7 @@
#ifdef BLDCFG_MEMORY_QUADRANK_TYPE
#define CFG_MEMORY_QUADRANK_TYPE BLDCFG_MEMORY_QUADRANK_TYPE
#else
- #define CFG_MEMORY_QUADRANK_TYPE DFLT_MEMORY_QUADRANK_TYPE
+ #define CFG_MEMORY_QUADRANK_TYPE QUADRANK_UNBUFFERED
#endif
#ifdef BLDCFG_MEMORY_RDIMM_CAPABLE
@@ -2060,31 +2060,31 @@
#ifdef BLDCFG_SCRUB_DRAM_RATE
#define CFG_SCRUB_DRAM_RATE BLDCFG_SCRUB_DRAM_RATE
#else
- #define CFG_SCRUB_DRAM_RATE DFLT_SCRUB_DRAM_RATE
+ #define CFG_SCRUB_DRAM_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_L2_RATE
#define CFG_SCRUB_L2_RATE BLDCFG_SCRUB_L2_RATE
#else
- #define CFG_SCRUB_L2_RATE DFLT_SCRUB_L2_RATE
+ #define CFG_SCRUB_L2_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_L3_RATE
#define CFG_SCRUB_L3_RATE BLDCFG_SCRUB_L3_RATE
#else
- #define CFG_SCRUB_L3_RATE DFLT_SCRUB_L3_RATE
+ #define CFG_SCRUB_L3_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_IC_RATE
#define CFG_SCRUB_IC_RATE BLDCFG_SCRUB_IC_RATE
#else
- #define CFG_SCRUB_IC_RATE DFLT_SCRUB_IC_RATE
+ #define CFG_SCRUB_IC_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_DC_RATE
#define CFG_SCRUB_DC_RATE BLDCFG_SCRUB_DC_RATE
#else
- #define CFG_SCRUB_DC_RATE DFLT_SCRUB_DC_RATE
+ #define CFG_SCRUB_DC_RATE (0)
#endif
#ifdef BLDCFG_ECC_SYNC_FLOOD
diff --git a/src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h b/src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h
index 6c84bcb..ff5b91c 100644
--- a/src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h
+++ b/src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h
@@ -747,7 +747,7 @@
#ifdef BLDCFG_VRM_SLEW_RATE
#define CFG_VRM_SLEW_RATE BLDCFG_VRM_SLEW_RATE
#else
- #define CFG_VRM_SLEW_RATE DFLT_VRM_SLEW_RATE
+ #define CFG_VRM_SLEW_RATE (5000)
#endif
#ifdef BLDCFG_VRM_MAXIMUM_CURRENT_LIMIT
@@ -789,7 +789,7 @@
#ifdef BLDCFG_VRM_NB_SLEW_RATE
#define CFG_VRM_NB_SLEW_RATE BLDCFG_VRM_NB_SLEW_RATE
#else
- #define CFG_VRM_NB_SLEW_RATE DFLT_VRM_SLEW_RATE
+ #define CFG_VRM_NB_SLEW_RATE (5000)
#endif
#ifdef BLDCFG_PLAT_NUM_IO_APICS
@@ -897,7 +897,7 @@
#ifdef BLDCFG_MEMORY_QUADRANK_TYPE
#define CFG_MEMORY_QUADRANK_TYPE BLDCFG_MEMORY_QUADRANK_TYPE
#else
- #define CFG_MEMORY_QUADRANK_TYPE DFLT_MEMORY_QUADRANK_TYPE
+ #define CFG_MEMORY_QUADRANK_TYPE QUADRANK_UNBUFFERED
#endif
#ifdef BLDCFG_MEMORY_RDIMM_CAPABLE
@@ -1029,31 +1029,31 @@
#ifdef BLDCFG_SCRUB_DRAM_RATE
#define CFG_SCRUB_DRAM_RATE BLDCFG_SCRUB_DRAM_RATE
#else
- #define CFG_SCRUB_DRAM_RATE DFLT_SCRUB_DRAM_RATE
+ #define CFG_SCRUB_DRAM_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_L2_RATE
#define CFG_SCRUB_L2_RATE BLDCFG_SCRUB_L2_RATE
#else
- #define CFG_SCRUB_L2_RATE DFLT_SCRUB_L2_RATE
+ #define CFG_SCRUB_L2_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_L3_RATE
#define CFG_SCRUB_L3_RATE BLDCFG_SCRUB_L3_RATE
#else
- #define CFG_SCRUB_L3_RATE DFLT_SCRUB_L3_RATE
+ #define CFG_SCRUB_L3_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_IC_RATE
#define CFG_SCRUB_IC_RATE BLDCFG_SCRUB_IC_RATE
#else
- #define CFG_SCRUB_IC_RATE DFLT_SCRUB_IC_RATE
+ #define CFG_SCRUB_IC_RATE (0)
#endif
#ifdef BLDCFG_SCRUB_DC_RATE
#define CFG_SCRUB_DC_RATE BLDCFG_SCRUB_DC_RATE
#else
- #define CFG_SCRUB_DC_RATE DFLT_SCRUB_DC_RATE
+ #define CFG_SCRUB_DC_RATE (0)
#endif
#ifdef BLDCFG_ECC_SYNC_FLOOD