commit 7adfe80469e32e10db0387b395c16d6494a0cd8e
author Angel Pons <th3fanbus@gmail.com> Fri Mar 26 12:20:46 2021 +0100
committer Nico Huber <nico.h@gmx.de> Sun Mar 28 18:00:49 2021 +0000
tree ddc099d44e52d78472b3111d42e8cbe29f2106a1
parent 498f1285d2b7227c0f0e52ad5ed43c249412d907

nb/intel/haswell: Replace `DMIBAR64` and `EPBAR64`

While 64-bit writes seem to work properly, there could be unknown
side-effects in some cases, e.g. when running in long mode. Since
reference code uses two 32-bit writes, follow suit.

Change-Id: I48ed3d94c7865b3a3cce52108e99cf1656b57fc2
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51855
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/northbridge/intel/haswell/northbridge.c

diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c
index ab42e72..3494422 100644
--- a/src/northbridge/intel/haswell/northbridge.c
+++ b/src/northbridge/intel/haswell/northbridge.c
@@ -469,7 +469,8 @@
 	reg32 &= ~(0xff << 16);
 	reg32 |= 1 | (1 << 16);
 	EPBAR32(EPLE1D) = reg32;
-	EPBAR64(EPLE1A) = CONFIG_FIXED_DMIBAR_MMIO_BASE;
+	EPBAR32(EPLE1A) = CONFIG_FIXED_DMIBAR_MMIO_BASE;
+	EPBAR32(EPLE1A + 4) = 0;
 
 	for (unsigned int i = 0; i <= 2; i++) {
 		const struct device *const dev = pcidev_on_root(1, i);
@@ -477,7 +478,8 @@
 		if (!dev || !dev->enabled)
 			continue;
 
-		EPBAR64(eple_a[i]) = (u64)PCI_DEV(0, 1, i);
+		EPBAR32(eple_a[i]) = (u32)PCI_DEV(0, 1, i);
+		EPBAR32(eple_a[i] + 4) = 0;
 
 		reg32 = EPBAR32(eple_d[i]);
 		reg32 &= ~(0xff << 16);
@@ -503,9 +505,11 @@
 	reg32 &= ~(0xffff << 16);
 	reg32 |= 1 | (2 << 16);
 	DMIBAR32(DMILE1D) = reg32;
-	DMIBAR64(DMILE1A) = CONFIG_FIXED_RCBA_MMIO_BASE;
+	DMIBAR32(DMILE1A) = CONFIG_FIXED_RCBA_MMIO_BASE;
+	DMIBAR32(DMILE1A + 4) = 0;
 
-	DMIBAR64(DMILE2A) = CONFIG_FIXED_EPBAR_MMIO_BASE;
+	DMIBAR32(DMILE2A) = CONFIG_FIXED_EPBAR_MMIO_BASE;
+	DMIBAR32(DMILE2A + 4) = 0;
 	reg32 = DMIBAR32(DMILE2D);
 	reg32 &= ~(0xff << 16);
 	reg32 |= 1 | (1 << 16);