commit 68680dd7cd1a2678406610e99400bd25bf7fa282
author Nico Huber <nico.huber@secunet.com> Tue Mar 31 17:34:52 2020 +0200
committer Matt DeVillier <matt.devillier@gmail.com> Thu Apr 02 20:30:22 2020 +0000
tree f587cbc24811dd99a40980c2880d042eedfaff7d
parent 35bff432e5456acec8e68adca6b496fda53c6c57

Trim `.acpi_fill_ssdt_generator` and `.acpi_inject_dsdt_generator`

These two identifiers were always very confusing. We're not filling and
injecting generators. We are filling SSDTs and injecting into the DSDT.
So drop the `_generator` suffix. Hopefully, this also makes ACPI look a
little less scary.

Change-Id: I6f0e79632c9c855f38fe24c0186388a25990c44d
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39977
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: David Guckian
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/drivers/intel/ish/ish.c

diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c
index d542bd3..256b486 100644
--- a/src/drivers/intel/ish/ish.c
+++ b/src/drivers/intel/ish/ish.c
@@ -40,10 +40,10 @@
 }
 
 static struct device_operations intel_ish_ops = {
-	.read_resources			= DEVICE_NOOP,
-	.set_resources			= DEVICE_NOOP,
-	.enable_resources		= DEVICE_NOOP,
-	.acpi_fill_ssdt_generator	= ish_fill_ssdt_generator,
+	.read_resources		= DEVICE_NOOP,
+	.set_resources		= DEVICE_NOOP,
+	.enable_resources	= DEVICE_NOOP,
+	.acpi_fill_ssdt		= ish_fill_ssdt_generator,
 };
 
 static void intel_ish_enable(struct device *dev)

src/drivers/intel/mipi_camera/camera.c

diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 0cada81..92fa00b 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -78,11 +78,11 @@
 }
 
 static struct device_operations camera_ops = {
-	.read_resources			= DEVICE_NOOP,
-	.set_resources			= DEVICE_NOOP,
-	.enable_resources		= DEVICE_NOOP,
-	.acpi_name			= camera_acpi_name,
-	.acpi_fill_ssdt_generator	= camera_fill_ssdt,
+	.read_resources		= DEVICE_NOOP,
+	.set_resources		= DEVICE_NOOP,
+	.enable_resources	= DEVICE_NOOP,
+	.acpi_name		= camera_acpi_name,
+	.acpi_fill_ssdt		= camera_fill_ssdt,
 };
 
 static void camera_enable(struct device *dev)

src/drivers/intel/wifi/wifi.c

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index e5efbe1..af7407d 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -90,17 +90,17 @@
 };
 
 struct device_operations device_ops = {
-	.read_resources           = pci_dev_read_resources,
-	.set_resources            = pci_dev_set_resources,
-	.enable_resources         = pci_dev_enable_resources,
-	.init                     = wifi_pci_dev_init,
+	.read_resources   = pci_dev_read_resources,
+	.set_resources    = pci_dev_set_resources,
+	.enable_resources = pci_dev_enable_resources,
+	.init             = wifi_pci_dev_init,
 #if CONFIG(GENERATE_SMBIOS_TABLES)
-	.get_smbios_data          = smbios_write_wifi,
+	.get_smbios_data  = smbios_write_wifi,
 #endif
-	.ops_pci                  = &pci_ops,
+	.ops_pci          = &pci_ops,
 #if CONFIG(HAVE_ACPI_TABLES)
-	.acpi_name                = generic_wifi_acpi_name,
-	.acpi_fill_ssdt_generator = intel_wifi_fill_ssdt,
+	.acpi_name        = generic_wifi_acpi_name,
+	.acpi_fill_ssdt   = intel_wifi_fill_ssdt,
 #endif
 };