commit 679c37aa8de55ae28fc4ff13b2dd45d3905e0c0b
author Martin Roth <martinroth@chromium.org> Tue Jul 13 14:38:33 2021 -0600
committer Martin Roth <martinroth@google.com> Wed Jul 14 20:24:12 2021 +0000
tree 1bd22c76d9c05f8f9d3f898c7282a3ff95ac5ace
parent 299558874c5c17a1294595bf3d2b6f0d0f7fcfc4

src/device: Remove DEVICE_PATH_ESPI & DEVICE_PATH_LPC

The ESPI & LPC keywords were added for the zork program, but it was
found that they weren't needed, so they were never used.  The previous
patch removes them from sconfig, so now they aren't needed in coreboot.

BUG=None
TEST=Build

Signed-off-by: Martin Roth <martin@coreboot.org>
Change-Id: I9ae7817bb63d69ee272103b2d1186f125e188950
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56278
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/device/device_const.c

diff --git a/src/device/device_const.c b/src/device/device_const.c
index 7e7f2f1..92bae37 100644
--- a/src/device/device_const.c
+++ b/src/device/device_const.c
@@ -157,12 +157,6 @@
 	case DEVICE_PATH_MMIO:
 		equal = (path1->mmio.addr == path2->mmio.addr);
 		break;
-	case DEVICE_PATH_ESPI:
-		equal = (path1->espi.addr == path2->espi.addr);
-		break;
-	case DEVICE_PATH_LPC:
-		equal = (path1->lpc.addr == path2->lpc.addr);
-		break;
 	case DEVICE_PATH_GPIO:
 		equal = (path1->gpio.id == path2->gpio.id);
 		break;

src/device/device_util.c

diff --git a/src/device/device_util.c b/src/device/device_util.c
index 8ee8afc..9e71287 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -218,14 +218,6 @@
 			snprintf(buffer, sizeof(buffer), "MMIO: %08lx",
 				 dev->path.mmio.addr);
 			break;
-		case DEVICE_PATH_ESPI:
-			snprintf(buffer, sizeof(buffer), "ESPI: %08lx",
-				 dev->path.espi.addr);
-			break;
-		case DEVICE_PATH_LPC:
-			snprintf(buffer, sizeof(buffer), "LPC: %08lx",
-				 dev->path.lpc.addr);
-			break;
 		case DEVICE_PATH_GPIO:
 			snprintf(buffer, sizeof(buffer), "GPIO: %d", dev->path.gpio.id);
 			break;

src/include/device/path.h

diff --git a/src/include/device/path.h b/src/include/device/path.h
index 0cdb997..934d3b3 100644
--- a/src/include/device/path.h
+++ b/src/include/device/path.h
@@ -19,8 +19,6 @@
 	DEVICE_PATH_SPI,
 	DEVICE_PATH_USB,
 	DEVICE_PATH_MMIO,
-	DEVICE_PATH_ESPI,
-	DEVICE_PATH_LPC,
 	DEVICE_PATH_GPIO,
 
 	/*
@@ -45,8 +43,6 @@
 		"DEVICE_PATH_SPI",		\
 		"DEVICE_PATH_USB",		\
 		"DEVICE_PATH_MMIO",		\
-		"DEVICE_PATH_ESPI",		\
-		"DEVICE_PATH_LPC",		\
 		"DEVICE_PATH_GPIO",		\
 }
 
@@ -110,14 +106,6 @@
 	uintptr_t addr;
 };
 
-struct espi_path {
-	uintptr_t addr;
-};
-
-struct lpc_path {
-	uintptr_t addr;
-};
-
 struct gpio_path {
 	unsigned int id;
 };
@@ -138,8 +126,6 @@
 		struct spi_path		spi;
 		struct usb_path		usb;
 		struct mmio_path	mmio;
-		struct espi_path	espi;
-		struct lpc_path		lpc;
 		struct gpio_path	gpio;
 	};
 };