| commit | 610b016caf3170fc2bd92603bd75c1e69d4cbeb6 | [log] [tgz] |
|---|---|---|
| author | Felix Singer <felixsinger@posteo.net> | Sun Dec 05 07:33:39 2021 +0100 |
| committer | Felix Singer <felixsinger@posteo.net> | Sun Dec 12 16:06:19 2021 +0000 |
| tree | 30ab1bd72bf1b35a3ec9d92db05d4639a500998c | |
| parent | 178153dc45896c9c82a3f1b5b10a0c1bad768fe8 [diff] |
mainboard: Drop `SataMode` setting from Cannon Lake devicetrees All Coffee Lake mainboards use the default value for the setting `SataMode`. Thus, drop it from their devicetree. Change-Id: Ibb329eb8b752c2220bb25f14fb6ae92dd8a308d6 Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/59889 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/mainboard/google/hatch/variants/akemi/variant.c b/src/mainboard/google/hatch/variants/akemi/variant.c index 00649c2..cc38362 100644 --- a/src/mainboard/google/hatch/variants/akemi/variant.c +++ b/src/mainboard/google/hatch/variants/akemi/variant.c
@@ -29,7 +29,6 @@ return; ssd_host->enabled = 0; cfg->SataSalpSupport = 0; - cfg->SataMode = 0; cfg->SataPortsEnable[1] = 0; cfg->SataPortsDevSlp[1] = 0; cfg->satapwroptimize = 0;
diff --git a/src/mainboard/google/hatch/variants/kindred/variant.c b/src/mainboard/google/hatch/variants/kindred/variant.c index 3510dbb..7e63526 100644 --- a/src/mainboard/google/hatch/variants/kindred/variant.c +++ b/src/mainboard/google/hatch/variants/kindred/variant.c
@@ -30,7 +30,6 @@ return; ssd_host->enabled = 0; cfg->SataSalpSupport = 0; - cfg->SataMode = 0; cfg->SataPortsEnable[1] = 0; cfg->SataPortsDevSlp[1] = 0; cfg->satapwroptimize = 0;
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index e0655c5..db57382 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb
@@ -1,7 +1,6 @@ chip soc/intel/cannonlake # FSP configuration - register "SataMode" = "0" # AHCI register "SataSalpSupport" = "0" register "satapwroptimize" = "1" register "SataPortsDevSlp[1]" = "1" # PCH_M2_SATA_DEVSLP1
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb index c8d6816..8b5c908 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb
@@ -199,7 +199,6 @@ device pci 16.4 off end # Management Engine Interface 3 device pci 16.5 off end # Management Engine Interface 4 device pci 17.0 on # SATA - register "SataMode" = "SATA_AHCI" register "satapwroptimize" = "1" register "SataSalpSupport" = "1" # Port 2 (M.2 / inner)