commit 60aef5f8b580195308a974585c74320c1c294a53
author Evgeny Zinoviev <me@ch1p.io> Thu Feb 04 01:12:42 2021 +0300
committer Patrick Georgi <pgeorgi@google.com> Tue Feb 09 07:46:55 2021 +0000
tree 586e1b11d9fc7f1888a2c2bc9cc3516b9958f1ff
parent eb26530e2c514ba0b1302dbbabe0954605d90539

mb/apple/macbookair4_2: Fix USB ports config

Disable unused ports and add comments.

Used 820-3023 board schematics as a source.

Change-Id: I2862546ca6f6929a86e77fae7337368742bb9ba8
Signed-off-by: Evgeny Zinoviev <me@ch1p.io>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50272
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

src/mainboard/apple/macbookair4_2/early_init.c

diff --git a/src/mainboard/apple/macbookair4_2/early_init.c b/src/mainboard/apple/macbookair4_2/early_init.c
index a32298d..7e2ec1b 100644
--- a/src/mainboard/apple/macbookair4_2/early_init.c
+++ b/src/mainboard/apple/macbookair4_2/early_init.c
@@ -6,20 +6,20 @@
 #include <cbfs.h>
 
 const struct southbridge_usb_port mainboard_usb_ports[] = {
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
-	{ 1, 0, -1 },
+	{ 1, 0, -1 }, /* USB HUB 1 */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 1, 0, -1 }, /* USB HUB 2 */
+	{ 1, 0, -1 }, /* Camera */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
+	{ 0, 0, -1 }, /* Unused */
 };
 
 void mainboard_get_spd(spd_raw_data *spd, bool id_only)