| commit | 5e6b0f0cac4ba5cde6114325ea69ec0e98c7e08f | [log] [tgz] |
|---|---|---|
| author | Elyes Haouas <ehaouas@noos.fr> | Tue Sep 13 09:55:49 2022 +0200 |
| committer | Felix Held <felix-coreboot@felixheld.de> | Wed Sep 14 12:01:24 2022 +0000 |
| tree | 06433b2873415812ac1fb28c51819cd89e4caa74 | |
| parent | 1fac2e20b8161e1dc93086b4c5498548827f1604 [diff] |
nb/intel: Use "if (!ptr)" in preference to "if (ptr == NULL)" Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Change-Id: I6d0d945011fa046b974c6f4554cb9fb15e523afb Reviewed-on: https://review.coreboot.org/c/coreboot/+/67578 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/northbridge/intel/ironlake/gma.c b/src/northbridge/intel/ironlake/gma.c index c816ba6..8084560 100644 --- a/src/northbridge/intel/ironlake/gma.c +++ b/src/northbridge/intel/ironlake/gma.c
@@ -172,7 +172,7 @@ /* Set the graphics memory to write combining. */ res = probe_resource(dev, PCI_BASE_ADDRESS_2); - if (res == NULL) { + if (!res) { printk(BIOS_DEBUG, "gma: memory resource not found.\n"); return; }
diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c index 1f55083..634ba90 100644 --- a/src/northbridge/intel/ironlake/raminit.c +++ b/src/northbridge/intel/ironlake/raminit.c
@@ -3207,7 +3207,7 @@ } if (s3resume) { - if (info.cached_training == NULL) { + if (!info.cached_training) { u32 reg32; printk(BIOS_ERR, "Couldn't find training data. Rebooting\n");