commit 5d029bbb90f63b6cfeb4198ba7b59ca3bf730b32
author Sean Rhodes <sean@starlabs.systems> Wed Sep 07 16:08:34 2022 +0100
committer Felix Held <felix-coreboot@felixheld.de> Tue Dec 06 19:30:12 2022 +0000
tree 3529881dc24363c3324e30acfe9a4b7ee81dde4e
parent bc8f859b2dae866817439e52eef23c0ee17cf921

mb/starlabs/lite/{glk,glkr}: Adjust THERMTRIP GPIO

Modify the configuration of GPIO_74 (PMIC Thermal Trip Point) as
in it's current configuration, it stops the laptop entering S5.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I0e31f095ff42a03e3ea1496fe67d69b0f1763a3c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67418
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>

src/mainboard/starlabs/lite/variants/glkr/gpio.c

diff --git a/src/mainboard/starlabs/lite/variants/glkr/gpio.c b/src/mainboard/starlabs/lite/variants/glkr/gpio.c
index 6bf8b61..11a7d31 100644
--- a/src/mainboard/starlabs/lite/variants/glkr/gpio.c
+++ b/src/mainboard/starlabs/lite/variants/glkr/gpio.c
@@ -169,7 +169,8 @@
 	/* GPIO_73:	WiFi Disable		*/
 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_73, 1, DEEP, NONE, IGNORE, DISPUPD),
 	/* GPIO_74:	PMIC_THERMTRIP#		*/
-	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_74, UP_20K, DEEP, NF1, TxDRxE, ENPU),
+	_PAD_CFG_STRUCT(GPIO_74, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF),
+		PAD_PULL(UP_20K) | PAD_IOSSTATE(IGNORE) | PAD_IOSTERM(ENPU)),
 	/* GPIO_75:	PROCHOT#_CPU		*/
 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_75, NONE, DEEP, NF1, TxDRxE, DISPUPD),
 	/* GPIO_211:	EMMC_RST#_CPU		*/