commit 5a04746714ddf1fdf4c0e1c9ed8cea4aa7fea511
author Elyes Haouas <ehaouas@noos.fr> Wed Dec 28 11:43:49 2022 +0100
committer Elyes Haouas <ehaouas@noos.fr> Wed Jan 04 07:22:58 2023 +0000
tree 7aa46ab7cc54288442bfa0f1667e49a1f425e59f
parent 046100590870042db986e622d5126b9daefc596e

spd.h: Move enum ddr2_module_type to ddr2.h

Move specific enum ddr2_module_type to <device/dram/ddr2.h>.

Change-Id: I748658f9b349bff9b1ebe2c0a6acf71bf2a221ce
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71546
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

src/device/dram/spd.c

diff --git a/src/device/dram/spd.c b/src/device/dram/spd.c
index deff674..738c05b 100644
--- a/src/device/dram/spd.c
+++ b/src/device/dram/spd.c
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */
 
+#include <device/dram/ddr2.h>
 #include <device/dram/spd.h>
 #include <spd.h>
 #include <stddef.h>
@@ -47,25 +48,25 @@
 	info->type_detail = MEMORY_TYPE_DETAIL_UNKNOWN;
 }
 
-static void convert_ddr2_module_type_to_spd_info(enum ddr2_module_type module_type,
+static void convert_ddr2_module_type_to_spd_info(enum spd_dimm_type_ddr2 module_type,
 						 struct spd_info *info)
 {
 	switch (module_type) {
-	case DDR2_SPD_RDIMM:
-	case DDR2_SPD_MINI_RDIMM:
+	case SPD_DDR2_DIMM_TYPE_RDIMM:
+	case SPD_DDR2_DIMM_TYPE_MINI_RDIMM:
 		info->form_factor = MEMORY_FORMFACTOR_RIMM;
 		info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED;
 		break;
-	case DDR2_SPD_UDIMM:
-	case DDR2_SPD_MINI_UDIMM:
+	case SPD_DDR2_DIMM_TYPE_UDIMM:
+	case SPD_DDR2_DIMM_TYPE_MINI_UDIMM:
 		info->form_factor = MEMORY_FORMFACTOR_DIMM;
 		info->type_detail = MEMORY_TYPE_DETAIL_UNBUFFERED;
 		break;
-	case DDR2_SPD_MICRO_DIMM:
+	case SPD_DDR2_DIMM_TYPE_MICRO_DIMM:
 		info->form_factor = MEMORY_FORMFACTOR_DIMM;
 		info->type_detail = MEMORY_TYPE_DETAIL_UNKNOWN;
 		break;
-	case DDR2_SPD_SODIMM:
+	case SPD_DDR2_DIMM_TYPE_SO_DIMM:
 		info->form_factor = MEMORY_FORMFACTOR_SODIMM;
 		info->type_detail = MEMORY_TYPE_DETAIL_UNKNOWN;
 		break;
@@ -210,11 +211,11 @@
 
 	switch (form_factor) {
 	case MEMORY_FORMFACTOR_DIMM:
-		return DDR2_SPD_UDIMM;
+		return SPD_DDR2_DIMM_TYPE_UDIMM;
 	case MEMORY_FORMFACTOR_RIMM:
-		return DDR2_SPD_RDIMM;
+		return SPD_DDR2_DIMM_TYPE_RDIMM;
 	case MEMORY_FORMFACTOR_SODIMM:
-		module_type = (memory_type == MEMORY_TYPE_DDR2) ? DDR2_SPD_SODIMM :
+		module_type = (memory_type == MEMORY_TYPE_DDR2) ? SPD_DDR2_DIMM_TYPE_SO_DIMM :
 									DDR3_SPD_SODIMM;
 		return module_type;
 	default: