commit 554713ee0a32cd8eabd75b276aeb82aa2570b030
author Angel Pons <th3fanbus@gmail.com> Sat Oct 24 23:23:07 2020 +0200
committer Patrick Georgi <pgeorgi@google.com> Mon Nov 02 10:41:15 2020 +0000
tree 48492cb71a23d95d7d7e0b798a0d95f01a9fb82e
parent 90cdf705aa36f51a997c9bf81cf40ae159b3ce46

azalia: Treat all negative return values as errors

Instead of checking whether the return value equals -1, just check if it
is negative. Some Azalia implementations already do it, but most do not.

Change-Id: I43ce72a01c07eff62d645db28c09584b386532ff
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46727
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/southbridge/intel/ibexpeak/azalia.c

diff --git a/src/southbridge/intel/ibexpeak/azalia.c b/src/southbridge/intel/ibexpeak/azalia.c
index 011bde6..c947092 100644
--- a/src/southbridge/intel/ibexpeak/azalia.c
+++ b/src/southbridge/intel/ibexpeak/azalia.c
@@ -42,7 +42,7 @@
 	u8 reg8;
 
 	/* Set Bit 0 to 1 to exit reset state (BAR + 0x8)[0] */
-	if (set_bits(base + HDA_GCTL_REG, 1, HDA_GCTL_CRST) == -1)
+	if (set_bits(base + HDA_GCTL_REG, 1, HDA_GCTL_CRST) < 0)
 		goto no_codec;
 
 	/* Write back the value once reset bit is set. */
@@ -138,7 +138,7 @@
 	printk(BIOS_DEBUG, "Azalia: Initializing codec #%d\n", addr);
 
 	/* 1 */
-	if (wait_for_ready(base) == -1) {
+	if (wait_for_ready(base) < 0) {
 		printk(BIOS_DEBUG, "  codec not ready.\n");
 		return;
 	}
@@ -146,7 +146,7 @@
 	reg32 = (addr << 28) | 0x000f0000;
 	write32(base + HDA_IC_REG, reg32);
 
-	if (wait_for_valid(base) == -1) {
+	if (wait_for_valid(base) < 0) {
 		printk(BIOS_DEBUG, "  codec not valid.\n");
 		return;
 	}
@@ -164,12 +164,12 @@
 
 	/* 3 */
 	for (i = 0; i < verb_size; i++) {
-		if (wait_for_ready(base) == -1)
+		if (wait_for_ready(base) < 0)
 			return;
 
 		write32(base + HDA_IC_REG, verb[i]);
 
-		if (wait_for_valid(base) == -1)
+		if (wait_for_valid(base) < 0)
 			return;
 	}
 	printk(BIOS_DEBUG, "Azalia: verb loaded.\n");
@@ -185,12 +185,12 @@
 	}
 
 	for (i = 0; i < pc_beep_verbs_size; i++) {
-		if (wait_for_ready(base) == -1)
+		if (wait_for_ready(base) < 0)
 			return;
 
 		write32(base + HDA_IC_REG, pc_beep_verbs[i]);
 
-		if (wait_for_valid(base) == -1)
+		if (wait_for_valid(base) < 0)
 			return;
 	}
 }