commit 553e2db9514919c14df63de7a8bfbfdbfe3def1b
author Yu-Ping Wu <yupingso@chromium.org> Wed Oct 16 11:05:54 2019 +0800
committer Patrick Georgi <pgeorgi@google.com> Thu Oct 17 15:04:13 2019 +0000
tree c4bb874c16e289a49c1a27ce6f45dae07667d798
parent 88ce8043c509b530909bbbd5f2778623c6872cdb

soc/mediatek/mt8183: Remove unnecessary DRAM register settings

In broadcast mode we only need to set registers for channel 0
instead of all channels.

BUG=none
BRANCH=kukui
TEST=emerge-kukui coreboot

Change-Id: I22a4b69fd40d1978fa7b12e8edaba00ce5d7787d
Signed-off-by: Yu-Ping Wu <yupingso@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36075
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

src/soc/mediatek/mt8183/dramc_init_setting.c

diff --git a/src/soc/mediatek/mt8183/dramc_init_setting.c b/src/soc/mediatek/mt8183/dramc_init_setting.c
index 26ff71a..32a8dd1 100644
--- a/src/soc/mediatek/mt8183/dramc_init_setting.c
+++ b/src/soc/mediatek/mt8183/dramc_init_setting.c
@@ -376,11 +376,9 @@
 		clrsetbits_le32(&ch[0].phy.b[b].dq[5], 0x3f << 8, rx_vref << 8);
 	}
 
-	for (u8 chn = 0; chn < CHANNEL_MAX; chn++) {
-		setbits_le32(&ch[chn].phy.b[0].dq[8], (0x1 << 0) | (0x1 << 1) | (0x1 << 2));
-		setbits_le32(&ch[chn].phy.b[1].dq[8], (0x1 << 0) | (0x1 << 1) | (0x1 << 2));
-		setbits_le32(&ch[chn].phy.ca_cmd[9], (0x1 << 0) | (0x1 << 1) | (0x1 << 2));
-	}
+	setbits_le32(&ch[0].phy.b[0].dq[8], (0x1 << 0) | (0x1 << 1) | (0x1 << 2));
+	setbits_le32(&ch[0].phy.b[1].dq[8], (0x1 << 0) | (0x1 << 1) | (0x1 << 2));
+	setbits_le32(&ch[0].phy.ca_cmd[9], (0x1 << 0) | (0x1 << 1) | (0x1 << 2));
 	dramc_gating_mode(1);
 
 	setbits_le32(&ch[0].phy.ca_cmd[8], 0x1 << 19);
@@ -1065,11 +1063,7 @@
 
 	for (size_t b = 0; b < 2; b++)
 		setbits_le32(&ch[0].phy.b[b].dq[3], (0x3 << 1) | (0x1 << 10));
-
-	dramc_set_broadcast(DRAMC_BROADCAST_OFF);
 	setbits_le32(&ch[0].phy.shu[0].ca_dll[0], 0x1 << 0);
-	setbits_le32(&ch[1].phy.shu[0].ca_dll[0], 0x1 << 0);
-	dramc_set_broadcast(DRAMC_BROADCAST_ON);
 
 	for (size_t b = 0; b < 2; b++)
 		clrsetbits_le32(&ch[0].phy.shu[0].b[b].dll[0],
@@ -1166,9 +1160,8 @@
 	setbits_le32(&ch[0].phy.misc_ctrl0,
 		(0xf << 0) | (0x1 << 9) | (0x1 << 24) | (0x1 << 31));
 
-	for (chn = 0; chn < CHANNEL_MAX; chn++)
-		setbits_le32(&ch[chn].phy.misc_ctrl1,
-			 (0x1 << 2) | (0x1 << 3) | (0x1 << 15) | (0x1 << 24));
+	setbits_le32(&ch[0].phy.misc_ctrl1,
+		 (0x1 << 2) | (0x1 << 3) | (0x1 << 15) | (0x1 << 24));
 	clrsetbits_le32(&ch[0].phy.b0_rxdvs[0], 0x1 << 24, 0x1 << 24);
 	clrsetbits_le32(&ch[0].phy.b1_rxdvs[0], 0x1 << 24, 0x1 << 24);
 	clrsetbits_le32(&ch[0].phy.ca_rxdvs0, 0x1 << 24, 0x0 << 24);