commit 532e043b66a6f05ba2d8a73b431913295ed89f11
author Elyes Haouas <ehaouas@noos.fr> Mon Feb 21 18:13:58 2022 +0100
committer Felix Held <felix-coreboot@felixheld.de> Thu Feb 24 17:10:02 2022 +0000
tree 2418a928b9b0b92e93b8527f9459c84e3a1db1fb
parent 95f8f92451097ad52ab49affbe21ea5782e6146d

treewide: Write minor version at acpi_create_fadt() function

When "fadt->FADT_MinorVersion" is not explicitly set to the right value, gcc sets it up to "0".
So set it correctly for treewide.

Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Change-Id: Ic9a8e097f78622cd78ba432e3b1141b142485b9a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62221
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
Reviewed-by: Lance Zhao

src/acpi/acpi.c

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c
index e3f77e0..456fd33 100644
--- a/src/acpi/acpi.c
+++ b/src/acpi/acpi.c
@@ -1507,6 +1507,7 @@
 	memcpy(header->asl_compiler_id, ASLC, 4);
 	header->asl_compiler_revision = asl_revision;
 
+	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
 	fadt->firmware_ctrl = (unsigned long) facs;
 	fadt->x_firmware_ctl_l = (unsigned long)facs;
 	fadt->x_firmware_ctl_h = 0;

src/soc/amd/picasso/acpi.c

diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c
index 2f55aec..cd8a0a0 100644
--- a/src/soc/amd/picasso/acpi.c
+++ b/src/soc/amd/picasso/acpi.c
@@ -106,7 +106,6 @@
 	fadt->flags |= cfg->fadt_flags; /* additional board-specific flags */
 
 	fadt->ARM_boot_arch = 0;	/* Must be zero if ACPI Revision <= 5.0 */
-	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
 
 	fadt->x_firmware_ctl_l = 0;	/* set to 0 if firmware_ctrl is used */
 	fadt->x_firmware_ctl_h = 0;

src/soc/amd/stoneyridge/acpi.c

diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index ec22704..4c3b625 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -98,7 +98,6 @@
 				ACPI_FADT_REMOTE_POWER_ON;
 
 	fadt->ARM_boot_arch = 0;	/* Must be zero if ACPI Revision <= 5.0 */
-	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
 
 	fadt->x_firmware_ctl_l = 0;	/* set to 0 if firmware_ctrl is used */
 	fadt->x_firmware_ctl_h = 0;

src/southbridge/amd/agesa/hudson/fadt.c

diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c
index fb88798..3aac450 100644
--- a/src/southbridge/amd/agesa/hudson/fadt.c
+++ b/src/southbridge/amd/agesa/hudson/fadt.c
@@ -63,7 +63,6 @@
 				ACPI_FADT_REMOTE_POWER_ON;
 
 	fadt->ARM_boot_arch = 0;	/* Must be zero if ACPI Revision <= 5.0 */
-	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
 
 	fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
 	fadt->x_pm1a_evt_blk.bit_width = 32;

src/southbridge/amd/cimx/sb800/fadt.c

diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c
index 101c2bf..9c280a1 100644
--- a/src/southbridge/amd/cimx/sb800/fadt.c
+++ b/src/southbridge/amd/cimx/sb800/fadt.c
@@ -87,7 +87,6 @@
 				ACPI_FADT_REMOTE_POWER_ON;
 
 	fadt->ARM_boot_arch = 0;	/* Must be zero if ACPI Revision <= 5.0 */
-	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
 
 	fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
 	fadt->x_pm1a_evt_blk.bit_width = 32;

src/southbridge/amd/pi/hudson/fadt.c

diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c
index a30202a..975b0fa 100644
--- a/src/southbridge/amd/pi/hudson/fadt.c
+++ b/src/southbridge/amd/pi/hudson/fadt.c
@@ -63,7 +63,6 @@
 				ACPI_FADT_REMOTE_POWER_ON;
 
 	fadt->ARM_boot_arch = 0;	/* Must be zero if ACPI Revision <= 5.0 */
-	fadt->FADT_MinorVersion = get_acpi_fadt_minor_version();
 
 	fadt->x_firmware_ctl_l = 0;	/* set to 0 if firmware_ctrl is used */
 	fadt->x_firmware_ctl_h = 0;