commit 4694b32511f2b0ecf732d640e0842fd17c44a660
author Felix Singer <felixsinger@posteo.net> Mon May 08 19:44:07 2023 +0200
committer Felix Singer <service+coreboot-gerrit@felixsinger.de> Thu Sep 21 22:34:15 2023 +0000
tree c9a96f1335423c85612dd0b3f70485d8096fac0b
parent 27a1c924e2bf47b07f838cff381f6c0cb05b2afe

mb/google/skyrim: Move selects from Kconfig.name to Kconfig

Selects should be done in the Kconfig file instead of Kconfig.name and
not mixed over both files.

Change-Id: I097d50a7af7c8ea48369806e8bb73734a8e84470
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75024
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/mainboard/google/skyrim/Kconfig

diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig
index 437fe89..59f6c67 100644
--- a/src/mainboard/google/skyrim/Kconfig
+++ b/src/mainboard/google/skyrim/Kconfig
@@ -3,6 +3,28 @@
 config BOARD_GOOGLE_BASEBOARD_SKYRIM
 	def_bool n
 
+config BOARD_GOOGLE_SKYRIM
+	select BOARD_GOOGLE_BASEBOARD_SKYRIM
+	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
+
+config BOARD_GOOGLE_WINTERHOLD
+	select BOARD_GOOGLE_BASEBOARD_SKYRIM
+	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
+	select FEATURE_DYNAMIC_DPTC
+
+config BOARD_GOOGLE_FROSTFLOW
+	select BOARD_GOOGLE_BASEBOARD_SKYRIM
+	select DRIVERS_GENESYSLOGIC_GL9755
+	select FEATURE_TABLET_MODE_DPTC
+	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
+
+config BOARD_GOOGLE_CRYSTALDRIFT
+	select BOARD_GOOGLE_BASEBOARD_SKYRIM
+
+config BOARD_GOOGLE_MARKARTH
+	select BOARD_GOOGLE_BASEBOARD_SKYRIM
+	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
+
 if BOARD_GOOGLE_BASEBOARD_SKYRIM
 
 config BOARD_SPECIFIC_OPTIONS

src/mainboard/google/skyrim/Kconfig.name

diff --git a/src/mainboard/google/skyrim/Kconfig.name b/src/mainboard/google/skyrim/Kconfig.name
index 7e45877..a68ecb06 100644
--- a/src/mainboard/google/skyrim/Kconfig.name
+++ b/src/mainboard/google/skyrim/Kconfig.name
@@ -2,27 +2,15 @@
 
 config BOARD_GOOGLE_SKYRIM
 	bool "->  Skyrim"
-	select BOARD_GOOGLE_BASEBOARD_SKYRIM
-	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
 
 config BOARD_GOOGLE_WINTERHOLD
 	bool "->  Winterhold"
-	select BOARD_GOOGLE_BASEBOARD_SKYRIM
-	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
-	select FEATURE_DYNAMIC_DPTC
 
 config BOARD_GOOGLE_FROSTFLOW
 	bool "->  Frostflow"
-	select BOARD_GOOGLE_BASEBOARD_SKYRIM
-	select DRIVERS_GENESYSLOGIC_GL9755
-	select FEATURE_TABLET_MODE_DPTC
-	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC
 
 config BOARD_GOOGLE_CRYSTALDRIFT
 	bool "->  Crystaldrift"
-	select BOARD_GOOGLE_BASEBOARD_SKYRIM
 
 config BOARD_GOOGLE_MARKARTH
 	bool "->  Markarth"
-	select BOARD_GOOGLE_BASEBOARD_SKYRIM
-	select SOC_AMD_COMMON_BLOCK_ACPI_DPTC