src: Make PCI ID define names shorter
Shorten define names containing PCI_{DEVICE,VENDOR}_ID_ with
PCI_{DID,VID}_ using the commands below, which also take care of some
spacing issues. An additional clean up of pci_ids.h is done in
CB:61531.
Used commands:
* find -type f -exec sed -i 's/PCI_\([DV]\)\(EVICE\|ENDOR\)_ID_\([_0-9A-Za-z]\{2\}\([_0-9A-Za-z]\{8\}\)*[_0-9A-Za-z]\{0,5\}\)\t/PCI_\1ID_\3\t\t/g'
* find -type f -exec sed -i 's/PCI_\([DV]\)\(EVICE\|ENDOR\)_ID_\([_0-9A-Za-z]*\)/PCI_\1ID_\3/g'
Change-Id: If9027700f53b6d0d3964c26a41a1f9b8f62be178
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39331
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
diff --git a/src/soc/intel/common/block/p2sb/p2sb.c b/src/soc/intel/common/block/p2sb/p2sb.c
index 16da691..03c341a 100644
--- a/src/soc/intel/common/block/p2sb/p2sb.c
+++ b/src/soc/intel/common/block/p2sb/p2sb.c
@@ -144,30 +144,30 @@
};
static const unsigned short pci_device_ids[] = {
- PCI_DEVICE_ID_INTEL_APL_P2SB,
- PCI_DEVICE_ID_INTEL_GLK_P2SB,
- PCI_DEVICE_ID_INTEL_LWB_P2SB,
- PCI_DEVICE_ID_INTEL_LWB_P2SB_SUPER,
- PCI_DEVICE_ID_INTEL_SKL_LP_P2SB,
- PCI_DEVICE_ID_INTEL_SKL_P2SB,
- PCI_DEVICE_ID_INTEL_KBL_P2SB,
- PCI_DEVICE_ID_INTEL_CNL_P2SB,
- PCI_DEVICE_ID_INTEL_CNP_H_P2SB,
- PCI_DEVICE_ID_INTEL_ICL_P2SB,
- PCI_DEVICE_ID_INTEL_CMP_P2SB,
- PCI_DEVICE_ID_INTEL_CMP_H_P2SB,
- PCI_DEVICE_ID_INTEL_TGL_P2SB,
- PCI_DEVICE_ID_INTEL_TGL_H_P2SB,
- PCI_DEVICE_ID_INTEL_EHL_P2SB,
- PCI_DEVICE_ID_INTEL_JSP_P2SB,
- PCI_DEVICE_ID_INTEL_ADP_P_P2SB,
- PCI_DEVICE_ID_INTEL_ADP_S_P2SB,
- PCI_DEVICE_ID_INTEL_ADP_M_P2SB,
+ PCI_DID_INTEL_APL_P2SB,
+ PCI_DID_INTEL_GLK_P2SB,
+ PCI_DID_INTEL_LWB_P2SB,
+ PCI_DID_INTEL_LWB_P2SB_SUPER,
+ PCI_DID_INTEL_SKL_LP_P2SB,
+ PCI_DID_INTEL_SKL_P2SB,
+ PCI_DID_INTEL_KBL_P2SB,
+ PCI_DID_INTEL_CNL_P2SB,
+ PCI_DID_INTEL_CNP_H_P2SB,
+ PCI_DID_INTEL_ICL_P2SB,
+ PCI_DID_INTEL_CMP_P2SB,
+ PCI_DID_INTEL_CMP_H_P2SB,
+ PCI_DID_INTEL_TGL_P2SB,
+ PCI_DID_INTEL_TGL_H_P2SB,
+ PCI_DID_INTEL_EHL_P2SB,
+ PCI_DID_INTEL_JSP_P2SB,
+ PCI_DID_INTEL_ADP_P_P2SB,
+ PCI_DID_INTEL_ADP_S_P2SB,
+ PCI_DID_INTEL_ADP_M_P2SB,
0,
};
static const struct pci_driver pmc __pci_driver = {
.ops = &device_ops,
- .vendor = PCI_VENDOR_ID_INTEL,
+ .vendor = PCI_VID_INTEL,
.devices = pci_device_ids,
};
diff --git a/src/soc/intel/common/block/p2sb/p2sblib.c b/src/soc/intel/common/block/p2sb/p2sblib.c
index d00606d..faef79a 100644
--- a/src/soc/intel/common/block/p2sb/p2sblib.c
+++ b/src/soc/intel/common/block/p2sb/p2sblib.c
@@ -16,7 +16,7 @@
if (pci_vid == 0xffff)
return true;
- if (pci_vid == PCI_VENDOR_ID_INTEL)
+ if (pci_vid == PCI_VID_INTEL)
return false;
printk(BIOS_ERR, "P2SB PCI_VENDOR_ID is invalid, unknown if hidden\n");
return true;