commit 3d8b6e25bbb688fee09f540ef331f4846b688669
author Angel Pons <th3fanbus@gmail.com> Mon Nov 02 13:40:11 2020 +0100
committer Angel Pons <th3fanbus@gmail.com> Tue Nov 03 19:09:34 2020 +0000
tree 2a6356f4718b58e3cb0e6f6f0b3d403d53834cb7
parent bf355e7159b3c812f748e366fdffdf0eade77e9d

sb/intel/bd82x6x/sata.c: Replace bad uses of `find_resource`

The `find_resource` function will never return null (will die instead).
Given that the existing code gracefully handles null pointers already,
it is reasonable to replace these function calls with `probe_resource`.

Change-Id: Ibd8f5ebd561cbde22ce5cd83de8270177bad1344
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47101
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>

src/southbridge/intel/bd82x6x/sata.c

diff --git a/src/southbridge/intel/bd82x6x/sata.c b/src/southbridge/intel/bd82x6x/sata.c
index 484f0f1..de1be62 100644
--- a/src/southbridge/intel/bd82x6x/sata.c
+++ b/src/southbridge/intel/bd82x6x/sata.c
@@ -40,28 +40,28 @@
 	if (sata_mode != 2)
 		return;
 
-	res = find_resource(dev, PCI_BASE_ADDRESS_0);
+	res = probe_resource(dev, PCI_BASE_ADDRESS_0);
 	if (res) {
 		res->base = 0x1f0;
 		res->size = 8;
 		res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 	}
 
-	res = find_resource(dev, PCI_BASE_ADDRESS_1);
+	res = probe_resource(dev, PCI_BASE_ADDRESS_1);
 	if (res) {
 		res->base = 0x3f4;
 		res->size = 4;
 		res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 	}
 
-	res = find_resource(dev, PCI_BASE_ADDRESS_2);
+	res = probe_resource(dev, PCI_BASE_ADDRESS_2);
 	if (res) {
 		res->base = 0x170;
 		res->size = 8;
 		res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
 	}
 
-	res = find_resource(dev, PCI_BASE_ADDRESS_3);
+	res = probe_resource(dev, PCI_BASE_ADDRESS_3);
 	if (res) {
 		res->base = 0x374;
 		res->size = 4;
@@ -77,7 +77,7 @@
 	if (sata_mode == 2) {
 		unsigned int i;
 		for (i = PCI_BASE_ADDRESS_0; i <= PCI_BASE_ADDRESS_3; i += 4) {
-			struct resource *const res = find_resource(dev, i);
+			struct resource *const res = probe_resource(dev, i);
 			if (res)
 				res->flags &= ~IORESOURCE_FIXED;
 		}