nb/intel/ironlake: Clean up DMIBAR/EPBAR registers
Several registers have been copy-pasted from i945 and do not exist on
Ironlake. Moreover, other register definitions were missing. Use the
newly-added definitions in existing code, in place of numerical offsets.
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 remains identical.
Change-Id: I8ac99166a8029dcdbb59028b4a7ee297249de5db
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45380
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c
index cf014fe..2cffa29 100644
--- a/src/northbridge/intel/ironlake/northbridge.c
+++ b/src/northbridge/intel/ironlake/northbridge.c
@@ -155,20 +155,20 @@
u32 reg32;
/* Clear error status bits */
- DMIBAR32(0x1c4) = 0xffffffff;
- DMIBAR32(0x1d0) = 0xffffffff;
+ DMIBAR32(DMIUESTS) = 0xffffffff;
+ DMIBAR32(DMICESTS) = 0xffffffff;
- reg32 = DMIBAR32(0x238);
+ reg32 = DMIBAR32(DMILLTC);
reg32 |= (1 << 29);
- DMIBAR32(0x238) = reg32;
+ DMIBAR32(DMILLTC) = reg32;
reg32 = DMIBAR32(0x1f8);
reg32 |= (1 << 16);
DMIBAR32(0x1f8) = reg32;
- reg32 = DMIBAR32(0x88);
+ reg32 = DMIBAR32(DMILCTL);
reg32 |= (1 << 1) | (1 << 0);
- DMIBAR32(0x88) = reg32;
+ DMIBAR32(DMILCTL) = reg32;
}
/* Disable unused PEG devices based on devicetree before PCI enumeration */