commit 36714d9fe6adc4e27ea3e98d2b4743087b0e2b4c
author Angel Pons <th3fanbus@gmail.com> Fri Mar 12 18:19:21 2021 +0100
committer Patrick Georgi <pgeorgi@google.com> Tue Mar 23 10:59:40 2021 +0000
tree ef584ee2cabf0c681a7d60cb8f50ac196a407a6c
parent c4ee714881c7f7bb7a9208b39c76d98578c434b1

haswell boards: Use zero length for disabled USB ports

For disabled USB ports, the length setting does not matter. In future
commits, disabled USB ports will end up with length field set to zero.

Change-Id: I7613e1b0c89c0b58eca790ca14fcd1633c8a93af
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51450
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Tristan Corrick <tristan@corrick.kiwi>

src/mainboard/asrock/h81m-hds/romstage.c

diff --git a/src/mainboard/asrock/h81m-hds/romstage.c b/src/mainboard/asrock/h81m-hds/romstage.c
index a5b667f..faac680 100644
--- a/src/mainboard/asrock/h81m-hds/romstage.c
+++ b/src/mainboard/asrock/h81m-hds/romstage.c
@@ -31,14 +31,14 @@
 	{ 0x0040, 1, 1, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 2, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 2, USB_PORT_BACK_PANEL },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
 	{ 0x0040, 1, 4, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 4, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 5, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 5, USB_PORT_BACK_PANEL },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
 };
 
 const struct usb3_port_setting mainboard_usb3_ports[MAX_USB3_PORTS] = {

src/mainboard/supermicro/x10slm-f/romstage.c

diff --git a/src/mainboard/supermicro/x10slm-f/romstage.c b/src/mainboard/supermicro/x10slm-f/romstage.c
index e555bea..ff77854 100644
--- a/src/mainboard/supermicro/x10slm-f/romstage.c
+++ b/src/mainboard/supermicro/x10slm-f/romstage.c
@@ -33,12 +33,12 @@
 	{ 0x0110, 1, 1, USB_PORT_BACK_PANEL },
 	{ 0x0110, 1, 2, USB_PORT_BACK_PANEL },
 	{ 0x0110, 1, 2, USB_PORT_BACK_PANEL },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
 	{ 0x0040, 1, 4, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 4, USB_PORT_BACK_PANEL },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
-	{ 0x0040, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
+	{ 0x0000, 0, USB_OC_PIN_SKIP, USB_PORT_SKIP },
 	{ 0x0040, 1, 6, USB_PORT_BACK_PANEL },
 	{ 0x0040, 1, 6, USB_PORT_BACK_PANEL },
 };