ec/google/wilco: Fix radio control command
This command is working as written, but it is not actually correct
as to what the format of the command should be. Fix this and add
define the other radios. There is no change in the command send to
the EC.
Change-Id: Ia551b08561b673d27bec2f900d97b746699b30c4
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32973
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
diff --git a/src/ec/google/wilco/commands.c b/src/ec/google/wilco/commands.c
index 9d4170f..626f9dd 100644
--- a/src/ec/google/wilco/commands.c
+++ b/src/ec/google/wilco/commands.c
@@ -159,7 +159,7 @@
int wilco_ec_radio_control(enum ec_radio radio, uint8_t state)
{
- uint8_t radio_control[3] = { 0, radio, state };
+ uint8_t radio_control[3] = { radio, RADIO_WRITE, state };
return wilco_ec_mailbox(WILCO_EC_MSG_DEFAULT, KB_RADIO_CONTROL,
radio_control, ARRAY_SIZE(radio_control),
diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h
index 9b7f2e5..9a18580 100644
--- a/src/ec/google/wilco/commands.h
+++ b/src/ec/google/wilco/commands.h
@@ -80,7 +80,15 @@
};
enum ec_radio {
- RADIO_WIFI = 0x02,
+ RADIO_WIFI = 0,
+ RADIO_WWAN,
+ RADIO_BT,
+};
+
+enum ec_radio_action {
+ RADIO_READ = 1,
+ RADIO_WRITE,
+ RADIO_TOGGLE,
};
enum ec_camera {