commit 35efba2bc06921d68ae4a345ab611f5d3ac3d5d1
author Felix Held <felix-coreboot@felixheld.de> Fri May 28 15:54:21 2021 +0200
committer Felix Held <felix-coreboot@felixheld.de> Tue Jun 01 12:49:26 2021 +0000
tree 14536f652d3f3fbc819990d0af03d1d55282f654
parent 67d958b64078216546e32d12ff8cae422e14c622

acpi: drop unused parameter from acpi_soc_fill_bert

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ic354824468f016a7857c6990024ae87db6fd00bf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55052
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Lance Zhao

src/acpi/acpi.c

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c
index 0874e6e..185825b 100644
--- a/src/acpi/acpi.c
+++ b/src/acpi/acpi.c
@@ -1565,7 +1565,7 @@
 	return false;
 }
 
-__weak void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length) {}
+__weak void acpi_soc_fill_bert(void **region, size_t *length) {}
 
 unsigned long __weak fw_cfg_acpi_tables(unsigned long start)
 {
@@ -1815,7 +1815,7 @@
 		size_t size;
 		printk(BIOS_DEBUG, "ACPI:    * BERT\n");
 		bert = (acpi_bert_t *) current;
-		acpi_soc_fill_bert(bert, &region, &size);
+		acpi_soc_fill_bert(&region, &size);
 		acpi_write_bert(bert, (uintptr_t)region, size);
 		if (bert->header.length >= sizeof(acpi_bert_t)) {
 			current += bert->header.length;

src/include/acpi/acpi.h

diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h
index d5e933b..dd00c40 100644
--- a/src/include/acpi/acpi.h
+++ b/src/include/acpi/acpi.h
@@ -1342,7 +1342,7 @@
 
 /* For crashlog. */
 bool acpi_is_boot_error_src_present(void);
-void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length);
+void acpi_soc_fill_bert(void **region, size_t *length);
 
 /* For ACPI S3 support. */
 void __noreturn acpi_resume(void *wake_vec);

src/soc/intel/common/block/acpi/acpi_bert.c

diff --git a/src/soc/intel/common/block/acpi/acpi_bert.c b/src/soc/intel/common/block/acpi/acpi_bert.c
index d090dfd..f94026d 100644
--- a/src/soc/intel/common/block/acpi/acpi_bert.c
+++ b/src/soc/intel/common/block/acpi/acpi_bert.c
@@ -8,9 +8,7 @@
 #include <intelblocks/crashlog.h>
 
 
-void acpi_soc_fill_bert(acpi_bert_t *bert,
-			void **region,
-			size_t *length)
+void acpi_soc_fill_bert(void **region, size_t *length)
 {
 	acpi_generic_error_status_t *status = NULL;
 	size_t cpu_record_size, pmc_record_size;