commit 35cb7851ab3e5b9b44857386b43690ce719fa655
author Pratik Prajapati <pratikkumar.v.prajapati@intel.com> Fri May 18 18:05:18 2018 -0700
committer Patrick Georgi <pgeorgi@google.com> Thu Jun 28 09:01:48 2018 +0000
tree f0dcb35497f92227ba0a4267d3c93076e15fa694
parent 5ccc73145fb98afb888cd616d0a39fa75b81288a

intel/common: change mca_configure API's def

add an unused param so that mca_configure can be called
by mp_run_on_all_cpus to run it on all cores.

Change-Id: I2395ee7fbedc829f040959b0021967f800693eeb
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati@intel.com>
Reviewed-on: https://review.coreboot.org/26391
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>

src/soc/intel/apollolake/cpu.c

diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c
index 9337eb3..6905894 100644
--- a/src/soc/intel/apollolake/cpu.c
+++ b/src/soc/intel/apollolake/cpu.c
@@ -73,7 +73,7 @@
 	/* TODO(adurbin): This should only be done on a cold boot. Also, some
 	 * of these banks are core vs package scope. For now every CPU clears
 	 * every bank. */
-	mca_configure();
+	mca_configure(NULL);
 
 	/* Set core MSRs */
 	reg_script_run(core_msr_script);

src/soc/intel/cannonlake/cpu.c

diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index dc413e2..ba87045 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -172,7 +172,7 @@
 	/* TODO(adurbin): This should only be done on a cold boot. Also, some
 	 * of these banks are core vs package scope. For now every CPU clears
 	 * every bank. */
-	mca_configure();
+	mca_configure(NULL);
 
 	/* Enable the local CPU apics */
 	enable_lapic_tpr();

src/soc/intel/common/block/cpu/cpulib.c

diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c
index c67904f..112a049 100644
--- a/src/soc/intel/common/block/cpu/cpulib.c
+++ b/src/soc/intel/common/block/cpu/cpulib.c
@@ -2,7 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2014 Google Inc.
- * Copyright (C) 2015 Intel Corporation.
+ * Copyright (C) 2015-2018 Intel Corporation.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -297,7 +297,7 @@
 	return msr.lo & 0xff;
 }
 
-void mca_configure(void)
+void mca_configure(void *unused)
 {
 	msr_t msr;
 	int i;
@@ -306,6 +306,7 @@
 	msr = rdmsr(IA32_MCG_CAP);
 	num_banks = msr.lo & 0xff;
 	msr.lo = msr.hi = 0;
+
 	for (i = 0; i < num_banks; i++) {
 		/* Clear the machine check status */
 		wrmsr(IA32_MC0_STATUS + (i * 4), msr);

src/soc/intel/common/block/include/intelblocks/cpulib.h

diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h
index 191459b..88f04b4 100644
--- a/src/soc/intel/common/block/include/intelblocks/cpulib.h
+++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h
@@ -157,6 +157,6 @@
 uint32_t cpu_get_max_turbo_ratio(void);
 
 /* Configure Machine Check Architecture support */
-void mca_configure(void);
+void mca_configure(void *unused);
 
 #endif	/* SOC_INTEL_COMMON_BLOCK_CPULIB_H */

src/soc/intel/skylake/cpu.c

diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 3a499ce..5535ec6 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -425,7 +425,7 @@
 	/* TODO(adurbin): This should only be done on a cold boot. Also, some
 	 * of these banks are core vs package scope. For now every CPU clears
 	 * every bank. */
-	mca_configure();
+	mca_configure(NULL);
 
 	/* Enable the local CPU apics */
 	enable_lapic_tpr();