soc/amd/picasso/acp: rename acp_update32 mask parameters
The name of the and_mask parameter was a bit misleading, due to the
function inverting the value. Renaming this into clear and set makes it
more obvious what those parameters will actually do.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: If307ab4858541861e22f8ff24ed178d47ba70fe5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52524
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/soc/amd/picasso/acp.c b/src/soc/amd/picasso/acp.c
index 69982f5..822c48a 100644
--- a/src/soc/amd/picasso/acp.c
+++ b/src/soc/amd/picasso/acp.c
@@ -15,13 +15,13 @@
#include <amdblocks/acpimmio.h>
#include <commonlib/helpers.h>
-static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t and_mask, uint32_t or_mask)
+static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set)
{
uint32_t val;
val = read32((void *)(bar + reg));
- val &= ~and_mask;
- val |= or_mask;
+ val &= ~clear;
+ val |= set;
write32((void *)(bar + reg), val);
}