Replace DEVICE_NOOP with noop_(set|read)_resources
`.read_resources` and `.set_resources` are the only two device
operations that are considered mandatory. Other function pointers
can be left NULL. Having dedicated no-op implementations for the
two mandatory fields should stop the leaking of no-op pointers to
other fields.
Change-Id: I6469a7568dc24317c95e238749d878e798b0a362
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40207
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/ec/compal/ene932/ec.c b/src/ec/compal/ene932/ec.c
index a022fa7..93d9154 100644
--- a/src/ec/compal/ene932/ec.c
+++ b/src/ec/compal/ene932/ec.c
@@ -122,7 +122,7 @@
static struct device_operations ops = {
.init = ene932_init,
- .read_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c
index c34082c..232df8e 100644
--- a/src/ec/google/chromeec/ec_lpc.c
+++ b/src/ec/google/chromeec/ec_lpc.c
@@ -438,7 +438,7 @@
static struct device_operations ops = {
.init = lpc_ec_init,
.read_resources = lpc_ec_read_resources,
- .set_resources = DEVICE_NOOP,
+ .set_resources = noop_set_resources,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = google_chromeec_acpi_name,
.acpi_fill_ssdt = google_chromeec_fill_ssdt_generator,
diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c
index f4bea48..7de4e02 100644
--- a/src/ec/google/wilco/chip.c
+++ b/src/ec/google/wilco/chip.c
@@ -219,7 +219,7 @@
static struct device_operations ops = {
.init = wilco_ec_init,
.read_resources = wilco_ec_read_resources,
- .set_resources = DEVICE_NOOP,
+ .set_resources = noop_set_resources,
.acpi_fill_ssdt = wilco_ec_fill_ssdt_generator,
.acpi_name = wilco_ec_acpi_name,
};
diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c
index f6acd218..4959db1 100644
--- a/src/ec/quanta/ene_kb3940q/ec.c
+++ b/src/ec/quanta/ene_kb3940q/ec.c
@@ -132,7 +132,7 @@
static struct device_operations ops = {
.init = ene_kb3940q_init,
- .read_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {
diff --git a/src/ec/quanta/it8518/ec.c b/src/ec/quanta/it8518/ec.c
index 19c07c5..9cb3755 100644
--- a/src/ec/quanta/it8518/ec.c
+++ b/src/ec/quanta/it8518/ec.c
@@ -146,7 +146,7 @@
static struct device_operations ops = {
.init = it8518_init,
- .read_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {
diff --git a/src/ec/roda/it8518/ec.c b/src/ec/roda/it8518/ec.c
index 02f4c9b..f4a2758 100644
--- a/src/ec/roda/it8518/ec.c
+++ b/src/ec/roda/it8518/ec.c
@@ -35,7 +35,7 @@
static struct device_operations ops = {
.init = it8518_init,
- .read_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
};
static struct pnp_info pnp_dev_info[] = {