cbfstool: Clean up code
cbfstool has diverged between coreboot upstream and the chromium tree.
Bring in some of the chromium changes, in particular the useful remainders
of cbf37fe (https://chromium-review.googlesource.com/176710)
- fix coding style
- mark unused variables explicitly unused
- remove some dead code
Change-Id: I354aaede8ce425ebe99d4c60c232feea62bf8a11
Signed-off-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/8577
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c
index bd9cdc0..6ac39ef 100644
--- a/util/cbfstool/common.c
+++ b/util/cbfstool/common.c
@@ -53,7 +53,8 @@
}
/* Buffer and file I/O */
-int buffer_create(struct buffer *buffer, size_t size, const char *name) {
+int buffer_create(struct buffer *buffer, size_t size, const char *name)
+{
buffer->name = strdup(name);
buffer->size = size;
buffer->data = (char *)malloc(buffer->size);
@@ -64,7 +65,8 @@
return (buffer->data == NULL);
}
-int buffer_from_file(struct buffer *buffer, const char *filename) {
+int buffer_from_file(struct buffer *buffer, const char *filename)
+{
FILE *fp = fopen(filename, "rb");
if (!fp) {
perror(filename);
@@ -88,7 +90,8 @@
return 0;
}
-int buffer_write_file(struct buffer *buffer, const char *filename) {
+int buffer_write_file(struct buffer *buffer, const char *filename)
+{
FILE *fp = fopen(filename, "wb");
if (!fp) {
perror(filename);
@@ -104,7 +107,8 @@
return 0;
}
-void buffer_delete(struct buffer *buffer) {
+void buffer_delete(struct buffer *buffer)
+{
assert(buffer);
if (buffer->name) {
free(buffer->name);