commit 2af174a7dc8fc85f142a895ab3240a83265f7e27
author Jonathan Neuschäfer <j.neuschaefer@gmx.net> Wed Oct 12 00:18:00 2016 +0200
committer Ronald G. Minnich <rminnich@gmail.com> Sat Oct 15 00:24:46 2016 +0200
tree c8ffe4b1a48e1d86f976887d16eb2b716c77f961
parent 03bf301d825ff0e360be67b4839bdb11f2f61774

riscv and power8: Convert printk/while(1) to die

Change-Id: I277cc9ae22cd33f2cd9ded808960349d09e8670d
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-on: https://review.coreboot.org/16984
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>

src/arch/riscv/trap_handler.c

diff --git a/src/arch/riscv/trap_handler.c b/src/arch/riscv/trap_handler.c
index 8120b66..f52ccf7 100644
--- a/src/arch/riscv/trap_handler.c
+++ b/src/arch/riscv/trap_handler.c
@@ -193,8 +193,7 @@
 		tf->gpr[destRegister] = value;
 	} else {
 		// panic, this should not have happened
-		printk(BIOS_DEBUG, "Code should not reach this path, misaligned on a non-64 bit store/load\n");
-		while(1);
+		die("Code should not reach this path, misaligned on a non-64 bit store/load\n");
 	}
 
 	// return to where we came from
@@ -223,8 +222,7 @@
 		}
 	} else {
 		// panic, this should not have happened
-		printk(BIOS_DEBUG, "Code should not reach this path, misaligned on a non-64 bit store/load\n");
-		while(1);
+		die("Code should not reach this path, misaligned on a non-64 bit store/load\n");
 	}
 
 	// return to where we came from

src/mainboard/emulation/qemu-power8/mainboard.c

diff --git a/src/mainboard/emulation/qemu-power8/mainboard.c b/src/mainboard/emulation/qemu-power8/mainboard.c
index 102f54c..6413f29 100644
--- a/src/mainboard/emulation/qemu-power8/mainboard.c
+++ b/src/mainboard/emulation/qemu-power8/mainboard.c
@@ -21,9 +21,7 @@
 {
 
 	if (!dev) {
-		printk(BIOS_EMERG, "No dev0; die\n");
-		while (1)
-			;
+		die("No dev0; die\n");
 	}
 
 	// Where does RAM live?

src/mainboard/emulation/qemu-riscv/mainboard.c

diff --git a/src/mainboard/emulation/qemu-riscv/mainboard.c b/src/mainboard/emulation/qemu-riscv/mainboard.c
index 111e9b1..c53ca7b 100644
--- a/src/mainboard/emulation/qemu-riscv/mainboard.c
+++ b/src/mainboard/emulation/qemu-riscv/mainboard.c
@@ -21,8 +21,7 @@
 {
 
 	if (!dev) {
-		printk(BIOS_EMERG, "No dev0; die\n");
-		while (1);
+		die("No dev0; die\n");
 	}
 
 	ram_resource(dev, 0, 2048, 32768);

src/mainboard/emulation/spike-riscv/mainboard.c

diff --git a/src/mainboard/emulation/spike-riscv/mainboard.c b/src/mainboard/emulation/spike-riscv/mainboard.c
index df2bdd6..eff95c0 100644
--- a/src/mainboard/emulation/spike-riscv/mainboard.c
+++ b/src/mainboard/emulation/spike-riscv/mainboard.c
@@ -28,8 +28,7 @@
 	const size_t ram_size = 1*GiB;
 
 	if (!dev) {
-		printk(BIOS_EMERG, "No dev0; die\n");
-		while (1);
+		die("No dev0; die\n");
 	}
 
 	ram_resource(dev, 0, 0x80000000/KiB, ram_size/KiB);