src/drivers: Remove needless '&' on function pointers
Change-Id: I7a99d0dcbc8ea1362a12a68fa519c49058d30a05
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/29868
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c
index d2a4b78..ebc22e0 100644
--- a/src/drivers/i2c/da7219/da7219.c
+++ b/src/drivers/i2c/da7219/da7219.c
@@ -114,8 +114,8 @@
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
- .acpi_name = &da7219_acpi_name,
- .acpi_fill_ssdt_generator = &da7219_fill_ssdt,
+ .acpi_name = da7219_acpi_name,
+ .acpi_fill_ssdt_generator = da7219_fill_ssdt,
#endif
};
@@ -126,5 +126,5 @@
struct chip_operations drivers_i2c_da7219_ops = {
CHIP_NAME("Dialog Semiconductor DA7219 Audio Codec")
- .enable_dev = &da7219_enable
+ .enable_dev = da7219_enable
};
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c
index df929b7..ca2dfaf 100644
--- a/src/drivers/i2c/generic/generic.c
+++ b/src/drivers/i2c/generic/generic.c
@@ -193,8 +193,8 @@
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
- .acpi_name = &i2c_generic_acpi_name,
- .acpi_fill_ssdt_generator = &i2c_generic_fill_ssdt_generator,
+ .acpi_name = i2c_generic_acpi_name,
+ .acpi_fill_ssdt_generator = i2c_generic_fill_ssdt_generator,
#endif
};
@@ -228,5 +228,5 @@
struct chip_operations drivers_i2c_generic_ops = {
CHIP_NAME("I2C Device")
- .enable_dev = &i2c_generic_enable
+ .enable_dev = i2c_generic_enable
};
diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c
index bccce75..952e3e4 100644
--- a/src/drivers/i2c/hid/hid.c
+++ b/src/drivers/i2c/hid/hid.c
@@ -51,8 +51,8 @@
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
- .acpi_name = &i2c_hid_acpi_name,
- .acpi_fill_ssdt_generator = &i2c_hid_fill_ssdt_generator,
+ .acpi_name = i2c_hid_acpi_name,
+ .acpi_fill_ssdt_generator = i2c_hid_fill_ssdt_generator,
#endif
};
@@ -69,5 +69,5 @@
struct chip_operations drivers_i2c_hid_ops = {
CHIP_NAME("I2C HID Device")
- .enable_dev = &i2c_hid_enable
+ .enable_dev = i2c_hid_enable
};
diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c
index e019b70..e10ccf1 100644
--- a/src/drivers/i2c/max98373/max98373.c
+++ b/src/drivers/i2c/max98373/max98373.c
@@ -91,8 +91,8 @@
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
- .acpi_name = &max98373_acpi_name,
- .acpi_fill_ssdt_generator = &max98373_fill_ssdt,
+ .acpi_name = max98373_acpi_name,
+ .acpi_fill_ssdt_generator = max98373_fill_ssdt,
};
static void max98373_enable(struct device *dev)
@@ -108,5 +108,5 @@
struct chip_operations drivers_i2c_max98373_ops = {
CHIP_NAME("Maxim MAX98373 Codec")
- .enable_dev = &max98373_enable
+ .enable_dev = max98373_enable
};
diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c
index ec05034..68a167d 100644
--- a/src/drivers/i2c/max98927/max98927.c
+++ b/src/drivers/i2c/max98927/max98927.c
@@ -87,8 +87,8 @@
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
- .acpi_name = &max98927_acpi_name,
- .acpi_fill_ssdt_generator = &max98927_fill_ssdt,
+ .acpi_name = max98927_acpi_name,
+ .acpi_fill_ssdt_generator = max98927_fill_ssdt,
};
static void max98927_enable(struct device *dev)
@@ -104,5 +104,5 @@
struct chip_operations drivers_i2c_max98927_ops = {
CHIP_NAME("Maxim MAX98927 Codec")
- .enable_dev = &max98927_enable
+ .enable_dev = max98927_enable
};
diff --git a/src/drivers/i2c/nau8825/nau8825.c b/src/drivers/i2c/nau8825/nau8825.c
index 86d4306..3f90512 100644
--- a/src/drivers/i2c/nau8825/nau8825.c
+++ b/src/drivers/i2c/nau8825/nau8825.c
@@ -103,8 +103,8 @@
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
- .acpi_name = &nau8825_acpi_name,
- .acpi_fill_ssdt_generator = &nau8825_fill_ssdt,
+ .acpi_name = nau8825_acpi_name,
+ .acpi_fill_ssdt_generator = nau8825_fill_ssdt,
#endif
};
@@ -115,5 +115,5 @@
struct chip_operations drivers_i2c_nau8825_ops = {
CHIP_NAME("Nuvoton NAU8825 Codec")
- .enable_dev = &nau8825_enable
+ .enable_dev = nau8825_enable
};
diff --git a/src/drivers/i2c/rt5663/rt5663.c b/src/drivers/i2c/rt5663/rt5663.c
index 38b2a98..1ce5993 100644
--- a/src/drivers/i2c/rt5663/rt5663.c
+++ b/src/drivers/i2c/rt5663/rt5663.c
@@ -91,8 +91,8 @@
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
- .acpi_name = &rt5663_acpi_name,
- .acpi_fill_ssdt_generator = &rt5663_fill_ssdt,
+ .acpi_name = rt5663_acpi_name,
+ .acpi_fill_ssdt_generator = rt5663_fill_ssdt,
};
static void rt5663_enable(struct device *dev)
@@ -102,5 +102,5 @@
struct chip_operations drivers_i2c_rt5663_ops = {
CHIP_NAME("Realtek RT5663 Codec")
- .enable_dev = &rt5663_enable
+ .enable_dev = rt5663_enable
};
diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c
index 0e98bcb..afd9e35 100644
--- a/src/drivers/i2c/sx9310/sx9310.c
+++ b/src/drivers/i2c/sx9310/sx9310.c
@@ -85,8 +85,8 @@
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
- .acpi_name = &i2c_sx9310_acpi_name,
- .acpi_fill_ssdt_generator = &i2c_sx9310_fill_ssdt,
+ .acpi_name = i2c_sx9310_acpi_name,
+ .acpi_fill_ssdt_generator = i2c_sx9310_fill_ssdt,
};
static void i2c_sx9310_enable(struct device *dev)
@@ -106,5 +106,5 @@
struct chip_operations drivers_i2c_sx9310_ops = {
CHIP_NAME(I2C_SX9310_ACPI_NAME)
- .enable_dev = &i2c_sx9310_enable
+ .enable_dev = i2c_sx9310_enable
};
diff --git a/src/drivers/i2c/tpm/chip.c b/src/drivers/i2c/tpm/chip.c
index 3dbe811..687ce05 100644
--- a/src/drivers/i2c/tpm/chip.c
+++ b/src/drivers/i2c/tpm/chip.c
@@ -78,8 +78,8 @@
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
- .acpi_name = &i2c_tpm_acpi_name,
- .acpi_fill_ssdt_generator = &i2c_tpm_fill_ssdt,
+ .acpi_name = i2c_tpm_acpi_name,
+ .acpi_fill_ssdt_generator = i2c_tpm_fill_ssdt,
};
static void i2c_tpm_enable(struct device *dev)
@@ -95,5 +95,5 @@
struct chip_operations drivers_i2c_tpm_ops = {
CHIP_NAME("I2C TPM")
- .enable_dev = &i2c_tpm_enable
+ .enable_dev = i2c_tpm_enable
};