commit 2a58e187af790dab8a9c1dbeebe4b57a9c259a3c
author Angel Pons <th3fanbus@gmail.com> Fri Feb 19 11:11:34 2021 +0100
committer Patrick Georgi <pgeorgi@google.com> Mon Feb 22 07:23:36 2021 +0000
tree 6232fc9cb188530addc84d0f048e0724e89c029f
parent 77330e5b153cba121cf246e6643bf659d16d0a77

mb/intel/harcuvar: Drop build guards for ENABLE_FSP_MEMORY_DOWN

Ensure the code gets build-tested for CONFIG_ENABLE_FSP_MEMORY_DOWN=n.

Change-Id: I6213e3e0ea3b2acfc97017739ac069ee3811d742
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50905
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>

src/mainboard/intel/harcuvar/romstage.c

diff --git a/src/mainboard/intel/harcuvar/romstage.c b/src/mainboard/intel/harcuvar/romstage.c
index 0373c01..027c56e 100644
--- a/src/mainboard/intel/harcuvar/romstage.c
+++ b/src/mainboard/intel/harcuvar/romstage.c
@@ -7,8 +7,6 @@
 #include <fsp/api.h>
 #include <fsp/soc_binding.h>
 
-#if CONFIG(ENABLE_FSP_MEMORY_DOWN)
-
 /*
  * Define platform specific Memory Down Configure structure.
  *
@@ -63,8 +61,6 @@
 	}
 };
 
-#endif /* CONFIG_ENABLE_FSP_MEMORY_DOWN */
-
 void mainboard_config_gpios(void);
 void mainboard_memory_init_params(FSPM_UPD *mupd);
 
@@ -103,7 +99,9 @@
 
 void mainboard_memory_init_params(FSPM_UPD *mupd)
 {
-#if CONFIG(ENABLE_FSP_MEMORY_DOWN)
+	if (!CONFIG(ENABLE_FSP_MEMORY_DOWN))
+		return;
+
 	uint8_t *spd_data_ptr = NULL;
 
 	/* Get SPD data pointer */
@@ -125,5 +123,4 @@
 		mupd->FspmConfig.PcdMemoryDown = 0;
 		mupd->FspmConfig.PcdMemoryDownConfigPtr = 0;
 	}
-#endif /* CONFIG_ENABLE_FSP_MEMORY_DOWN */
 }