commit 29405483cedca2035d1d0229a2ec893e53a6dcc9
author Felix Held <felix-coreboot@felixheld.de> Fri May 28 16:01:57 2021 +0200
committer Felix Held <felix-coreboot@felixheld.de> Mon Jun 07 18:25:57 2021 +0000
tree 685c76c525fe50823db4047315321273fc367b63
parent 8c8b4d26db910cb3e85a9940a1d9da828a725b22

acpi: rename acpi_soc_fill_bert and add return value

The return value indicates if the function has found valid BERT data and
wrote them to the region and length parameters. This will be used in a
follow-up patch to remove the acpi_is_boot_error_src_present function
call in the common code.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Iaaa3eed51645e1b3bc904c6279d171e3a10d59be
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55053
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Lance Zhao
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/acpi/acpi.c

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c
index 185825b..2326169 100644
--- a/src/acpi/acpi.c
+++ b/src/acpi/acpi.c
@@ -1565,7 +1565,10 @@
 	return false;
 }
 
-__weak void acpi_soc_fill_bert(void **region, size_t *length) {}
+__weak enum cb_err acpi_soc_get_bert_region(void **region, size_t *length)
+{
+	return CB_ERR;
+}
 
 unsigned long __weak fw_cfg_acpi_tables(unsigned long start)
 {
@@ -1815,7 +1818,7 @@
 		size_t size;
 		printk(BIOS_DEBUG, "ACPI:    * BERT\n");
 		bert = (acpi_bert_t *) current;
-		acpi_soc_fill_bert(&region, &size);
+		acpi_soc_get_bert_region(&region, &size);
 		acpi_write_bert(bert, (uintptr_t)region, size);
 		if (bert->header.length >= sizeof(acpi_bert_t)) {
 			current += bert->header.length;