commit 27a1c924e2bf47b07f838cff381f6c0cb05b2afe
author Felix Singer <felixsinger@posteo.net> Mon May 08 19:42:20 2023 +0200
committer Felix Singer <service+coreboot-gerrit@felixsinger.de> Thu Sep 21 22:33:58 2023 +0000
tree df30a1d7e8c5639c3684f65ff40e2fa0c6b551a2
parent cef2ca946ed4bf04b8a51b137f7788ab04f5d8b6

mb/google/gru: Move selects from Kconfig.name to Kconfig

Selects should be done in the Kconfig file instead of Kconfig.name and
not mixed over both files.

Change-Id: Id7f9b598cc9df51ddf664b851172cc96a710c580
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75023
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/mainboard/google/gru/Kconfig

diff --git a/src/mainboard/google/gru/Kconfig b/src/mainboard/google/gru/Kconfig
index 23926b6..837b06d 100644
--- a/src/mainboard/google/gru/Kconfig
+++ b/src/mainboard/google/gru/Kconfig
@@ -3,6 +3,24 @@
 config BOARD_GOOGLE_GRU_COMMON  # Umbrella option to be selected by variant boards.
 	def_bool n
 
+config BOARD_GOOGLE_KEVIN
+	select BOARD_GOOGLE_GRU_COMMON
+
+config BOARD_GOOGLE_GRU
+	select BOARD_GOOGLE_GRU_COMMON
+
+config BOARD_GOOGLE_BOB
+	select BOARD_GOOGLE_GRU_COMMON
+
+config BOARD_GOOGLE_SCARLET
+	select BOARD_GOOGLE_GRU_COMMON
+
+config BOARD_GOOGLE_NEFARIO
+	select BOARD_GOOGLE_GRU_COMMON
+
+config BOARD_GOOGLE_RAINIER
+	select BOARD_GOOGLE_GRU_COMMON
+
 if BOARD_GOOGLE_GRU_COMMON
 
 # Most Grus have TPM2 but later Kevins don't... decide this in one place for

src/mainboard/google/gru/Kconfig.name

diff --git a/src/mainboard/google/gru/Kconfig.name b/src/mainboard/google/gru/Kconfig.name
index 04571c8..5d8f215 100644
--- a/src/mainboard/google/gru/Kconfig.name
+++ b/src/mainboard/google/gru/Kconfig.name
@@ -2,24 +2,18 @@
 
 config BOARD_GOOGLE_KEVIN
 	bool "->  Kevin (Samsung Chromebook Plus)"
-	select BOARD_GOOGLE_GRU_COMMON
 
 config BOARD_GOOGLE_GRU
 	bool "->  Gru"
-	select BOARD_GOOGLE_GRU_COMMON
 
 config BOARD_GOOGLE_BOB
 	bool "->  Bob (Asus Chromebook Flip C101PA)"
-	select BOARD_GOOGLE_GRU_COMMON
 
 config BOARD_GOOGLE_SCARLET
 	bool "->  Scarlet"
-	select BOARD_GOOGLE_GRU_COMMON
 
 config BOARD_GOOGLE_NEFARIO
 	bool "->  Nefario"
-	select BOARD_GOOGLE_GRU_COMMON
 
 config BOARD_GOOGLE_RAINIER
 	bool "->  Rainier"
-	select BOARD_GOOGLE_GRU_COMMON