util/lint: Add a check for touchpads using the "probed" flag
As of commit 2cf52d80a6ec ("mb/*/{device,override}tree: Set touchpads to
use detect (vs probed) flag") all touchpads in the tree have been
switched from using the 'probed' flag to 'detect.' Add a lint check to
ensure no touchpads are added with the probed flag.
TEST=manually change one touchpad to use 'probed' flag and ensure lint
check catches it.
Change-Id: Ie0aee2e3778fc56c6c21c97995738a147a1fa0d4
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67486
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
diff --git a/util/lint/lint-stable-028-touchpad-probed-warning b/util/lint/lint-stable-028-touchpad-probed-warning
new file mode 100755
index 0000000..3878dfb
--- /dev/null
+++ b/util/lint/lint-stable-028-touchpad-probed-warning
@@ -0,0 +1,29 @@
+#!/usr/bin/env sh
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# DESCR: Check that no touchpad uses the "probed" flag
+
+FAIL=0
+
+TESTFILE1="src/mainboard/google/eve/devicetree.cb"
+EXPECTED_FAILURES=1
+
+# Configure to make sure tests fail
+if [ "$1" = "--test" ]; then
+ sed -i.bak "/^.*register \"generic.desc\" = \"\"Touchpad\"\"/a \t\t\t\tregister \"generic.probed\" = \"1\"" "${TESTFILE1}"
+ echo "Expect ${EXPECTED_FAILURES} failures."
+ exit 0
+elif [ "$1" = "--reset" ]; then
+ mv "${TESTFILE1}.bak" "${TESTFILE1}"
+ exit 0
+fi
+
+for f in `find src/mainboard/ -name *tree.cb`; do
+ if grep -B8 "probed\" = \"1\"" $f | grep -q "Touchpad"; then
+ echo "ERROR: in $f:"
+ echo " Use of the 'probed' flag for touchpads is deprecated; use 'detect' instead"
+ FAIL=1
+ fi
+done
+
+exit $FAIL