src/drivers: Remove unnecessary space after casts
Change-Id: I16689da893b5a0c3254364759d435281cb3e1caf
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69803
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/drivers/amd/agesa/heapmanager.c b/src/drivers/amd/agesa/heapmanager.c
index 26947f1..8a82efe 100644
--- a/src/drivers/amd/agesa/heapmanager.c
+++ b/src/drivers/amd/agesa/heapmanager.c
@@ -42,7 +42,7 @@
memset(base, 0, BIOS_HEAP_SIZE);
printk(BIOS_DEBUG, "Wiped HEAP at [%08x - %08x]\n",
- (unsigned int)(uintptr_t)base, (unsigned int)(uintptr_t) base + BIOS_HEAP_SIZE - 1);
+ (unsigned int)(uintptr_t)base, (unsigned int)(uintptr_t)base + BIOS_HEAP_SIZE - 1);
}
#if defined(HEAP_CALLOUT_RUNTIME) && ENV_RAMSTAGE
@@ -345,7 +345,7 @@
}
}
- AllocParams->BufferPointer = (UINT8 *)((UINT8 *) AllocNodePtr + sizeof(BIOS_BUFFER_NODE));
+ AllocParams->BufferPointer = (UINT8 *)((UINT8 *)AllocNodePtr + sizeof(BIOS_BUFFER_NODE));
AllocParams->BufferLength = AllocNodePtr->BufferSize;
return AGESA_SUCCESS;
diff --git a/src/drivers/aspeed/common/ast_post.c b/src/drivers/aspeed/common/ast_post.c
index 08bc42c..856e4e5 100644
--- a/src/drivers/aspeed/common/ast_post.c
+++ b/src/drivers/aspeed/common/ast_post.c
@@ -740,9 +740,9 @@
passcnt[dqsip]++;
tag[dqsip][dlli] = 'P';
if (dlli < pass[dqidly][dqsip][0])
- pass[dqidly][dqsip][0] = (u16) dlli;
+ pass[dqidly][dqsip][0] = (u16)dlli;
if (dlli > pass[dqidly][dqsip][1])
- pass[dqidly][dqsip][1] = (u16) dlli;
+ pass[dqidly][dqsip][1] = (u16)dlli;
} else if (passcnt[dqsip] >= 5)
break;
else {
diff --git a/src/drivers/i2c/ptn3460/ptn3460.c b/src/drivers/i2c/ptn3460/ptn3460.c
index 25ed98a..46719dc 100644
--- a/src/drivers/i2c/ptn3460/ptn3460.c
+++ b/src/drivers/i2c/ptn3460/ptn3460.c
@@ -63,7 +63,7 @@
static void ptn3460_init(struct device *dev)
{
struct ptn_3460_config cfg;
- uint8_t edid_data[PTN_EDID_LEN], edid_tab, *ptr = (uint8_t *) &cfg;
+ uint8_t edid_data[PTN_EDID_LEN], edid_tab, *ptr = (uint8_t *)&cfg;
int i, val;
/* Guard against re-initialization of the device */
@@ -108,7 +108,7 @@
/* Mainboard can modify the configuration data.
Write back configuration data to PTN3460 if modified by mainboard */
if (mb_adjust_cfg(&cfg) == PTN_CFG_MODIFIED) {
- ptr = (uint8_t *) &cfg;
+ ptr = (uint8_t *)&cfg;
for (i = 0; i < sizeof(struct ptn_3460_config); i++) {
val = i2c_dev_writeb_at(dev, PTN_CONFIG_OFF + i, *ptr++);
if (val < 0) {
diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c
index 80de2df..ea8cf3d 100644
--- a/src/drivers/i2c/tpm/tis.c
+++ b/src/drivers/i2c/tpm/tis.c
@@ -78,7 +78,7 @@
}
ASSERT(chip.vendor.send);
- rc = chip.vendor.send(&chip, (uint8_t *) sbuf, count);
+ rc = chip.vendor.send(&chip, (uint8_t *)sbuf, count);
if (rc < 0) {
printk(BIOS_DEBUG, "%s: tpm_send error\n", __func__);
goto out;
@@ -111,7 +111,7 @@
out_recv:
- rc = chip.vendor.recv(&chip, (uint8_t *) rbuf, rbufsiz);
+ rc = chip.vendor.recv(&chip, (uint8_t *)rbuf, rbufsiz);
if (rc < 0)
printk(BIOS_DEBUG, "%s: tpm_recv: error %d\n", __func__, rc);
out:
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index f0f580b..aae1ff8 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -261,14 +261,14 @@
tcount = fvih->Count;
#elif CONFIG(DISPLAY_FSP_VERSION_INFO_2)
- uint8_t *hobstart = (uint8_t *) hob;
+ uint8_t *hobstart = (uint8_t *)hob;
hobstart += sizeof(EFI_HOB_GUID_TYPE);
const SMBIOS_TABLE_TYPE_OEM_INTEL_FVI *stfvi =
(SMBIOS_TABLE_TYPE_OEM_INTEL_FVI *)hobstart;
const INTEL_FIRMWARE_VERSION_INFO *fvi;
- str_ptr = ((char *) &(stfvi->Fvi[0])) +
+ str_ptr = ((char *)&(stfvi->Fvi[0])) +
(stfvi->Count * sizeof(INTEL_FIRMWARE_VERSION_INFO));
tcount = stfvi->Count;
fvi = &stfvi->Fvi[0];
diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index 87f77a2..678892a 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -96,7 +96,7 @@
struct fsp_multi_phase_params multi_phase_params;
struct fsp_multi_phase_get_number_of_phases_params multi_phase_get_number;
- supd = (FSPS_UPD *) (uintptr_t)(hdr->cfg_region_offset + hdr->image_base);
+ supd = (FSPS_UPD *)(uintptr_t)(hdr->cfg_region_offset + hdr->image_base);
fsp_verify_upd_header_signature(supd->FspUpdHeader.Signature, FSPS_UPD_SIGNATURE);
@@ -127,7 +127,7 @@
soc_load_logo(upd);
/* Call SiliconInit */
- silicon_init = (void *) (uintptr_t)(hdr->image_base +
+ silicon_init = (void *)(uintptr_t)(hdr->image_base +
hdr->fsp_silicon_init_entry_offset);
fsp_debug_before_silicon_init(silicon_init, supd, upd);
@@ -165,7 +165,7 @@
return;
/* Call MultiPhaseSiInit */
- multi_phase_si_init = (void *) (uintptr_t)(hdr->image_base +
+ multi_phase_si_init = (void *)(uintptr_t)(hdr->image_base +
hdr->fsp_multi_phase_si_init_entry_offset);
/* Implementing multi_phase_si_init() is optional as per FSP 2.2 spec */
diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c
index f165307..844eb8e 100644
--- a/src/drivers/ipmi/ipmi_fru.c
+++ b/src/drivers/ipmi/ipmi_fru.c
@@ -36,8 +36,8 @@
while (retry_count <= MAX_FRU_BUSY_RETRY) {
ret = ipmi_message(port, IPMI_NETFN_STORAGE, 0x0,
- IPMI_READ_FRU_DATA, (const unsigned char *) req,
- sizeof(*req), (unsigned char *) &rsp, sizeof(rsp));
+ IPMI_READ_FRU_DATA, (const unsigned char *)req,
+ sizeof(*req), (unsigned char *)&rsp, sizeof(rsp));
if (rsp.resp.completion_code == 0x81) {
/* Device is busy */
if (retry_count == MAX_FRU_BUSY_RETRY) {
diff --git a/src/drivers/ipmi/ipmi_ops.c b/src/drivers/ipmi/ipmi_ops.c
index d9b3256..18547c5 100644
--- a/src/drivers/ipmi/ipmi_ops.c
+++ b/src/drivers/ipmi/ipmi_ops.c
@@ -21,8 +21,8 @@
req.initial_countdown_val = countdown;
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_SET_WDG_TIMER,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
printk(BIOS_ERR, "IPMI: %s set wdt command failed "
@@ -35,7 +35,7 @@
/* Reset command to start timer */
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_RESET_WDG_TIMER, NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
printk(BIOS_ERR, "IPMI: %s reset wdt command failed "
@@ -59,7 +59,7 @@
/* Get current timer first */
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_GET_WDG_TIMER, NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s get wdt command failed "
@@ -79,8 +79,8 @@
req = rsp.data;
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_SET_WDG_TIMER,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &resp, sizeof(resp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&resp, sizeof(resp));
if (ret < sizeof(struct ipmi_rsp) || resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s set wdt command stop timer failed "
@@ -107,7 +107,7 @@
ret = ipmi_message(port, IPMI_NETFN_APPLICATION, 0x0,
IPMI_BMC_GET_SYSTEM_GUID, NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n",
@@ -130,8 +130,8 @@
}
ret = ipmi_message(port, IPMI_NETFN_STORAGE, 0x0,
- IPMI_ADD_SEL_ENTRY, (const unsigned char *) sel,
- 16, (unsigned char *) &rsp, sizeof(rsp));
+ IPMI_ADD_SEL_ENTRY, (const unsigned char *)sel,
+ 16, (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n",
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.c b/src/drivers/ipmi/ocp/ipmi_ocp.c
index 9f583be..e75edca 100644
--- a/src/drivers/ipmi/ocp/ipmi_ocp.c
+++ b/src/drivers/ipmi/ocp/ipmi_ocp.c
@@ -29,8 +29,8 @@
req.cpu1_hi = xeon_sp_ppin[1].hi;
}
ret = ipmi_message(dev->path.pnp.port, IPMI_NETFN_OEM, 0x0, IPMI_OEM_SET_PPIN,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (ret=%d resp=0x%x)\n",
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c b/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
index 7b0b9ea..8ef379e 100644
--- a/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
+++ b/src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
@@ -11,7 +11,7 @@
struct ipmi_rsp rsp;
ret = ipmi_message(port, IPMI_NETFN_OEM, 0x0,
- IPMI_BMC_SET_POST_START, NULL, 0, (u8 *) &rsp,
+ IPMI_BMC_SET_POST_START, NULL, 0, (u8 *)&rsp,
sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
@@ -45,7 +45,7 @@
ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0,
IPMI_OEM_GET_BIOS_BOOT_ORDER,
NULL, 0,
- (unsigned char *) &rsp, sizeof(rsp));
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (read ret=%d resp=0x%x)\n",
@@ -58,8 +58,8 @@
SET_CMOS_AND_VALID_BIT(req.boot_mode);
ret = ipmi_message(CONFIG_BMC_KCS_BASE, IPMI_NETFN_OEM, 0x0,
IPMI_OEM_SET_BIOS_BOOT_ORDER,
- (const unsigned char *) &req, sizeof(req),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&req, sizeof(req),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(struct ipmi_rsp) || rsp.resp.completion_code) {
printk(BIOS_ERR, "IPMI: %s command failed (sent ret=%d resp=0x%x)\n",
diff --git a/src/drivers/ipmi/supermicro_oem.c b/src/drivers/ipmi/supermicro_oem.c
index 7af4e3b..c63da5f 100644
--- a/src/drivers/ipmi/supermicro_oem.c
+++ b/src/drivers/ipmi/supermicro_oem.c
@@ -36,8 +36,8 @@
bios_ver.ver = IPMI_LUN0_AC_SET_BIOS_VER;
ret = ipmi_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING,
- (const unsigned char *) &bios_ver, sizeof(bios_ver),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&bios_ver, sizeof(bios_ver),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(rsp) || rsp.completion_code) {
printk(BIOS_ERR, "BMC_IPMI: %s command failed (ret=%d resp=0x%x)\n",
__func__, ret, rsp.completion_code);
@@ -55,8 +55,8 @@
bios_ver.ver = IPMI_LUN0_AC_SET_BIOS_DATE;
ret = ipmi_message(kcs_port, IPMI_NETFN_OEM, 0, IPMI_LUN0_SET_BIOS_STRING,
- (const unsigned char *) &bios_ver, sizeof(bios_ver),
- (unsigned char *) &rsp, sizeof(rsp));
+ (const unsigned char *)&bios_ver, sizeof(bios_ver),
+ (unsigned char *)&rsp, sizeof(rsp));
if (ret < sizeof(rsp) || rsp.completion_code) {
printk(BIOS_ERR, "BMC_IPMI: %s command failed (ret=%d resp=0x%x)\n",
__func__, ret, rsp.completion_code);
diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c
index 235c909..e0dc58b 100644
--- a/src/drivers/net/ne2k.c
+++ b/src/drivers/net/ne2k.c
@@ -281,7 +281,7 @@
c = inb(eth_nic_base + NE_ASIC_OFFSET + NE_RESET);
outb(c, eth_nic_base + NE_ASIC_OFFSET + NE_RESET);
- (void) inb(0x84);
+ (void)inb(0x84);
outb(D8390_COMMAND_STP | D8390_COMMAND_RD2, eth_nic_base + D8390_P0_COMMAND);
outb(D8390_RCR_MON, eth_nic_base + D8390_P0_RCR);
diff --git a/src/drivers/pc80/vga/vga.c b/src/drivers/pc80/vga/vga.c
index dde0355..d970fea 100644
--- a/src/drivers/pc80/vga/vga.c
+++ b/src/drivers/pc80/vga/vga.c
@@ -186,7 +186,7 @@
/* plane 2 */
vga_sr_write(0x02, 0x04);
- p = (unsigned char *) VGA_FB;
+ p = (unsigned char *)VGA_FB;
for (i = 0; i < count; i++) {
for (j = 0; j < 32; j++) {
if (j < height)
@@ -262,7 +262,7 @@
void
vga_line_write(unsigned int line, const char *string)
{
- unsigned short *p = (unsigned short *) VGA_FB + (80 * line);
+ unsigned short *p = (unsigned short *)VGA_FB + (80 * line);
int i, len = strlen(string);
for (i = 0; i < 80; i++) {
diff --git a/src/drivers/pc80/vga/vga_io.c b/src/drivers/pc80/vga/vga_io.c
index e4b1eb9..2bf2af4 100644
--- a/src/drivers/pc80/vga/vga_io.c
+++ b/src/drivers/pc80/vga/vga_io.c
@@ -147,10 +147,10 @@
{
unsigned char ret;
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
outb(index, VGA_AR_INDEX);
ret = inb(VGA_AR_VALUE_READ);
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
return ret;
}
@@ -158,10 +158,10 @@
void
vga_ar_write(unsigned char index, unsigned char value)
{
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
outb(index, VGA_AR_INDEX);
outb(value, VGA_AR_VALUE_WRITE);
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
}
void
@@ -209,17 +209,17 @@
void
vga_palette_enable(void)
{
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
outb(0x00, VGA_AR_INDEX);
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
}
void
vga_palette_disable(void)
{
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
outb(0x20, VGA_AR_INDEX);
- (void) inb(VGA_STAT1);
+ (void)inb(VGA_STAT1);
}
unsigned char