mainboard/google/kahlee: Update memory.c
This fixes some issues with the initial implementation that was copied
from reef.
- The board ID value shouldn't be size_t - it's not a size.
- Kahlee doesn't even need the memory.c file - it uses an SoDIMM.
BUG=b:68293392
TEST=build stoney platforms, boot kahleebo
Change-Id: Ife5660d36912e887edfd0365a9f16c5a172c9c86
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/22515
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/mainboard/google/kahlee/variants/baseboard/memory.c b/src/mainboard/google/kahlee/variants/baseboard/memory.c
index 511241f..ae8734e 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/memory.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/memory.c
@@ -17,7 +17,7 @@
#include <baseboard/variants.h>
#include <variant/gpio.h>
-size_t __attribute__((weak)) variant_board_id(void)
+uint8_t __attribute__((weak)) variant_board_id(void)
{
gpio_t pads[] = {
[3] = MEM_CONFIG3,
@@ -26,5 +26,5 @@
[0] = MEM_CONFIG0,
};
- return gpio_pullup_base2_value(pads, ARRAY_SIZE(pads));
+ return gpio_base2_value(pads, ARRAY_SIZE(pads));
}