commit 15066ba8d4696b299d93e5872ee035fc20570d13
author Nick Vaccaro <nvaccaro@google.com> Fri Oct 01 13:15:26 2021 -0700
committer Nick Vaccaro <nvaccaro@google.com> Mon Oct 04 17:15:47 2021 +0000
tree e4320273a02ccbafa905e7bfb0707dae572c4519
parent a62b41819ceda4108b3a97cf72f55fc470347d58

driver/intel/pmc_mux/conn: Move typec_orientation enum to coreboot_tables.h

Move the locally declared typec_orientation enum from chip.h to
coreboot_tables.h.

Change enum typec_orientation name to type_c_orientation for consistency
with contents of coreboot_tables.h.

Rename TYPEC_ORIENTATION_FOLLOW_CC to TYPEC_ORIENTATION_NONE.

BUG=b:149830546
TEST="emerge-volteer coreboot" and make sure it compiles successfully.

Change-Id: I24c9177be72b0c9831791aa7d1f7b1236309c9cd
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58084
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Furquan Shaikh <furquan@google.com>

src/drivers/intel/pmc_mux/conn/conn.c

diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c
index b6bf371..7a622c8 100644
--- a/src/drivers/intel/pmc_mux/conn/conn.c
+++ b/src/drivers/intel/pmc_mux/conn/conn.c
@@ -1,8 +1,10 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */
 
 #include <acpi/acpigen.h>
+#include <boot/coreboot_tables.h>
 #include <console/console.h>
 #include <intelblocks/acpi.h>
+
 #include "chip.h"
 
 static const char *conn_acpi_name(const struct device *dev)
@@ -12,14 +14,14 @@
 	return name;
 }
 
-static const char *orientation_to_str(enum typec_orientation ori)
+static const char *orientation_to_str(enum type_c_orientation ori)
 {
 	switch (ori) {
 	case TYPEC_ORIENTATION_NORMAL:
 		return "normal";
 	case TYPEC_ORIENTATION_REVERSE:
 		return "reverse";
-	case TYPEC_ORIENTATION_FOLLOW_CC: /* Intentional fallthrough */
+	case TYPEC_ORIENTATION_NONE: /* Intentional fallthrough */
 	default:
 		return "";
 	}
@@ -52,11 +54,11 @@
 	 * The kernel assumes that these Type-C signals (SBUs and HSLs) follow the CC lines,
 	 * unless they are explicitly called out otherwise.
 	 */
-	if (config->sbu_orientation != TYPEC_ORIENTATION_FOLLOW_CC)
+	if (config->sbu_orientation != TYPEC_ORIENTATION_NONE)
 		acpi_dp_add_string(dsd, "sbu-orientation",
 				   orientation_to_str(config->sbu_orientation));
 
-	if (config->hsl_orientation != TYPEC_ORIENTATION_FOLLOW_CC)
+	if (config->hsl_orientation != TYPEC_ORIENTATION_NONE)
 		acpi_dp_add_string(dsd, "hsl-orientation",
 				   orientation_to_str(config->hsl_orientation));