commit 0f89a113134639cd1af653f08a005427655bce58
author Arthur Heymans <arthur@aheymans.xyz> Mon Apr 18 17:14:37 2022 +0200
committer Felix Held <felix-coreboot@felixheld.de> Wed Apr 20 09:37:34 2022 +0000
tree 1ae6201215bb4349f619c1463b125735d7d3a1df
parent 35a124ec77953820b1d2cd49d88451d0d0179035

nb/intel/snb: Reduce scope of functions

Change-Id: Idefbe15c5f7c7169d9b60079b90cd02affb261ca
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63701
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

src/northbridge/intel/sandybridge/raminit.h

diff --git a/src/northbridge/intel/sandybridge/raminit.h b/src/northbridge/intel/sandybridge/raminit.h
index dd4e572..fa9fa98 100644
--- a/src/northbridge/intel/sandybridge/raminit.h
+++ b/src/northbridge/intel/sandybridge/raminit.h
@@ -9,10 +9,6 @@
 #define BOOT_PATH_RESET		1
 #define BOOT_PATH_RESUME	2
 
-void sdram_initialize(struct pei_data *pei_data);
-void save_mrc_data(struct pei_data *pei_data);
 void mainboard_fill_pei_data(struct pei_data *pei_data);
-int fixup_sandybridge_errata(void);
-void setup_sdram_meminfo(struct pei_data *pei_data);
 
 #endif /* RAMINIT_H */

src/northbridge/intel/sandybridge/raminit_mrc.c

diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c
index fbb2b6e..0bc33b6 100644
--- a/src/northbridge/intel/sandybridge/raminit_mrc.c
+++ b/src/northbridge/intel/sandybridge/raminit_mrc.c
@@ -49,7 +49,7 @@
 
 #define MRC_CACHE_VERSION 0
 
-void save_mrc_data(struct pei_data *pei_data)
+static void save_mrc_data(struct pei_data *pei_data)
 {
 	u16 c1, c2, checksum;
 
@@ -127,7 +127,7 @@
  *
  * @param pei_data: configuration data for UEFI PEI reference code
  */
-void sdram_initialize(struct pei_data *pei_data)
+static void sdram_initialize(struct pei_data *pei_data)
 {
 	int (*entry)(struct pei_data *pei_data) __attribute__((regparm(1)));
 
@@ -320,6 +320,8 @@
 	RCBA32(FD) |= PCH_DISABLE_P2P;
 }
 
+static void setup_sdram_meminfo(struct pei_data *pei_data);
+
 void perform_raminit(int s3resume)
 {
 	struct pei_data pei_data;
@@ -390,7 +392,7 @@
 	setup_sdram_meminfo(&pei_data);
 }
 
-void setup_sdram_meminfo(struct pei_data *pei_data)
+static void setup_sdram_meminfo(struct pei_data *pei_data)
 {
 	u32 addr_decoder_common, addr_decode_ch[2];
 	struct memory_info *mem_info;