commit 0f007d8ceb7e5c852c645cf773df5c5c37cbf411
author Furquan Shaikh <furquan@google.com> Fri Apr 24 06:41:18 2020 -0700
committer Furquan Shaikh <furquan@google.com> Tue Apr 28 19:21:49 2020 +0000
tree 2891d4d1b03e6a5b5d0695a88bc7272f849cb55e
parent f939df7a959b645cc79872623d72bed475c21157

device: Constify struct device * parameter to write_acpi_tables

.write_acpi_tables() should not be updating the device structure. This
change makes the struct device * argument to it as const.

Change-Id: I50d013e83a404e0a0e3837ca16fa75c7eaa0e14a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40701
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>

src/soc/intel/broadwell/acpi.c

diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c
index c45bd76..feec61f 100644
--- a/src/soc/intel/broadwell/acpi.c
+++ b/src/soc/intel/broadwell/acpi.c
@@ -586,7 +586,7 @@
 	return current;
 }
 
-unsigned long northbridge_write_acpi_tables(struct device *const dev,
+unsigned long northbridge_write_acpi_tables(const struct device *const dev,
 					    unsigned long current,
 					    struct acpi_rsdp *const rsdp)
 {

src/soc/intel/broadwell/igd.c

diff --git a/src/soc/intel/broadwell/igd.c b/src/soc/intel/broadwell/igd.c
index dbb4205..6ab9b199 100644
--- a/src/soc/intel/broadwell/igd.c
+++ b/src/soc/intel/broadwell/igd.c
@@ -592,7 +592,7 @@
 }
 
 static unsigned long
-gma_write_acpi_tables(struct device *const dev, unsigned long current,
+gma_write_acpi_tables(const struct device *const dev, unsigned long current,
 		struct acpi_rsdp *const rsdp)
 {
 	igd_opregion_t *opregion = (igd_opregion_t *)current;

src/soc/intel/broadwell/include/soc/acpi.h

diff --git a/src/soc/intel/broadwell/include/soc/acpi.h b/src/soc/intel/broadwell/include/soc/acpi.h
index 7da5b5c..2d39707 100644
--- a/src/soc/intel/broadwell/include/soc/acpi.h
+++ b/src/soc/intel/broadwell/include/soc/acpi.h
@@ -16,6 +16,6 @@
 void acpi_fill_in_fadt(acpi_fadt_t *fadt);
 unsigned long acpi_madt_irq_overrides(unsigned long current);
 void acpi_init_gnvs(global_nvs_t *gnvs);
-unsigned long northbridge_write_acpi_tables(struct device *dev,
+unsigned long northbridge_write_acpi_tables(const struct device *dev,
 	unsigned long current, struct acpi_rsdp *rsdp);
 #endif

src/soc/intel/broadwell/lpc.c

diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c
index a381bb1..22547fc 100644
--- a/src/soc/intel/broadwell/lpc.c
+++ b/src/soc/intel/broadwell/lpc.c
@@ -596,7 +596,7 @@
 	}
 }
 
-static unsigned long broadwell_write_acpi_tables(struct device *device,
+static unsigned long broadwell_write_acpi_tables(const struct device *device,
 						 unsigned long current,
 						 struct acpi_rsdp *rsdp)
 {