commit 0d98cc48446f355212a5a4a6e92c72b7458032d8
author Fred Reitberger <reitbergerfred@gmail.com> Tue Oct 18 14:33:51 2022 -0400
committer Felix Held <felix-coreboot@felixheld.de> Fri Oct 21 14:48:42 2022 +0000
tree 6b3cfe2649e62da05ca04d29634d97987407e672
parent 164b93bd9c8f2f6be1f22c1dbd23db99c848fbcc

soc/amd/morgana/i2c: Remove to-do after review

Reviewed files and values match morgana ppr #57396, rev 1.52

Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: I9d058b0f61b4784a1d83289e75705a6415405d0b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68547
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>

src/soc/amd/morgana/i2c.c

diff --git a/src/soc/amd/morgana/i2c.c b/src/soc/amd/morgana/i2c.c
index 13b3959..92dd00d 100644
--- a/src/soc/amd/morgana/i2c.c
+++ b/src/soc/amd/morgana/i2c.c
@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-/* TODO: Update for Morgana */
-
 #include <amdblocks/i2c.h>
 #include <console/console.h>
 #include <soc/i2c.h>

src/soc/amd/morgana/include/soc/i2c.h

diff --git a/src/soc/amd/morgana/include/soc/i2c.h b/src/soc/amd/morgana/include/soc/i2c.h
index 900bdca..8946336 100644
--- a/src/soc/amd/morgana/include/soc/i2c.h
+++ b/src/soc/amd/morgana/include/soc/i2c.h
@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
-/* TODO: Update for Morgana */
-
 #ifndef AMD_MORGANA_I2C_H
 #define AMD_MORGANA_I2C_H
 
@@ -12,7 +10,8 @@
 #define GPIO_I2C1_SCL		BIT(1)
 #define GPIO_I2C2_SCL		BIT(2)
 #define GPIO_I2C3_SCL		BIT(3)
-#define GPIO_I2C_MASK		(BIT(0) | BIT(1) | BIT(2) | BIT(3))
+#define GPIO_I2C_MASK		(GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
+				 GPIO_I2C2_SCL | GPIO_I2C3_SCL)
 
 
 #define I2C0_SCL_PIN			GPIO_145