commit 06897d1b1a7cc0af355c90cb317a8ad8210ea413
author Kyösti Mälkki <kyosti.malkki@gmail.com> Sat Nov 23 07:23:40 2019 +0200
committer Patrick Georgi <pgeorgi@google.com> Wed Jun 03 12:19:24 2020 +0000
tree f28e1944bdd6917861475c18e82d6e745021b4b0
parent b8125e033643fdfe101ac69c0c3add111fc613ad

mb/aopen/dxplplusu: Control SMI related FADT entries

When no SMI is installed, FADT should not advertise a trigger
mechanism that does not respond.

Board does not support ACPI S4 or C-states or P-states.

Change-Id: If83efb72e076d404468259e312a5afac625f04af
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41904
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

src/mainboard/aopen/dxplplusu/fadt.c

diff --git a/src/mainboard/aopen/dxplplusu/fadt.c b/src/mainboard/aopen/dxplplusu/fadt.c
index 36465eb..339c243 100644
--- a/src/mainboard/aopen/dxplplusu/fadt.c
+++ b/src/mainboard/aopen/dxplplusu/fadt.c
@@ -37,11 +37,13 @@
 	fadt->preferred_pm_profile = 0; /* PM_MOBILE; */
 
 	fadt->sci_int = 0x9;
-	fadt->smi_cmd = APM_CNT;
-	fadt->acpi_enable = ACPI_ENABLE;
-	fadt->acpi_disable = ACPI_DISABLE;
-	fadt->s4bios_req = S4_BIOS;
-	fadt->pstate_cnt = PST_CONTROL;
+
+	if (CONFIG(HAVE_SMI_HANDLER)) {
+		fadt->smi_cmd = APM_CNT;
+		fadt->acpi_enable = ACPI_ENABLE;
+		fadt->acpi_disable = ACPI_DISABLE;
+		fadt->pstate_cnt = PST_CONTROL;
+	}
 
 	fadt->pm1a_evt_blk = pmbase;
 	fadt->pm1b_evt_blk = 0x0;
@@ -60,7 +62,6 @@
 	fadt->gpe0_blk_len = 8;
 	fadt->gpe1_blk_len = 0;
 	fadt->gpe1_base = 0;
-	fadt->cst_cnt = 0; /* CST_CONTROL; */
 	fadt->p_lvl2_lat = 1;
 	fadt->p_lvl3_lat = 85;
 	fadt->flush_size = 1024;