mb/dell: Fix uninitialized variables usage
Coverity detects uninitialized variables through PASS_BY_REFERENCE
usage. Fix this issue by initializing variables before their uage.
Found-by: Coverity CID 1429765, 1429772, 1429780
TEST=None
Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: Ie583b072a76949fb3f17c1271a6427ee942db0ce
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45611
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
diff --git a/src/mainboard/dell/optiplex_9010/sch5545_ec.c b/src/mainboard/dell/optiplex_9010/sch5545_ec.c
index c77aef1..8894d8b 100644
--- a/src/mainboard/dell/optiplex_9010/sch5545_ec.c
+++ b/src/mainboard/dell/optiplex_9010/sch5545_ec.c
@@ -421,7 +421,7 @@
uint16_t sch5545_get_ec_fw_version(void)
{
- uint8_t val;
+ uint8_t val = 0;
uint16_t ec_fw_version;
/* Read the FW version currently loaded used by EC */
@@ -499,7 +499,7 @@
void sch5545_ec_hwm_early_init(void)
{
- uint8_t val;
+ uint8_t val = 0;
int i;
printk(BIOS_DEBUG, "%s\n", __func__);
@@ -605,7 +605,7 @@
void sch5545_ec_hwm_init(void *unused)
{
- uint8_t val, val_2fc, chassis_type, fan_speed_full = 0;
+ uint8_t val = 0, val_2fc, chassis_type, fan_speed_full = 0;
printk(BIOS_DEBUG, "%s\n", __func__);
sch5545_emi_init(0x2e);